From 958e2486a477ec56eee0d6384a796e27be9e68cb Mon Sep 17 00:00:00 2001 From: RA80533 <32469082+RA80533@users.noreply.github.com> Date: Thu, 27 Apr 2023 18:07:53 -0400 Subject: [PATCH] Try-catch `os.popen()` for command failures --- setup.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 3f150612..25a73c18 100755 --- a/setup.py +++ b/setup.py @@ -202,8 +202,12 @@ def get_compiler_settings(version_str): # Homebrew installs odbc_config pipe = os.popen('odbc_config --cflags --libs 2>/dev/null') - cflags, ldflags = pipe.readlines() - exit_status = pipe.close() + try: + cflags, ldflags = pipe.readlines() + except ValueError: # The command failed + cflags, ldflags = '', '' + finally: + exit_status = pipe.close() if exit_status is None: settings['extra_compile_args'].extend(shlex.split(cflags))