Skip to content

Remove MMTK_PLAN from CompileThirdPartyHeap #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove MMTK_PLAN from CompileThirdPartyHeap #73

wants to merge 1 commit into from
+0 −4

Conversation

@caizixian
Copy link
Member

@caizixian caizixian commented May 28, 2021

Since we have runtime plan selection support now, this option doesn't make sense anymore.

@caizixian caizixian requested a review from wenyuzhao May 28, 2021 10:57
@qinsoon
Copy link
Member

qinsoon commented May 28, 2021

The features should also be removed from Cargo.toml and the code. Besides, we need to 1) merge Wenyu's changes to the running script to support env vars per build and 2) modify the configs in ci-perf-kit to select plans by env vars.

@caizixian
Copy link
Member Author

caizixian commented May 29, 2021

The features should also be removed from Cargo.toml and the code. Besides, we need to 1) merge Wenyu's changes to the running script to support env vars per build and 2) modify the configs in ci-perf-kit to select plans by env vars.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenyuzhao wenyuzhao Awaiting requested review from wenyuzhao

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caizixian @qinsoon