Skip to content

Commit 295cfbd

Browse files
committed
chore: better support for windows
1 parent 7dd6f4c commit 295cfbd

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

.changeset/nice-plants-prove.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@rocket/cli': patch
3+
---
4+
5+
Better support for windows paths

packages/cli/src/normalizeConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export async function normalizeConfig(inConfig) {
3636
watch: true,
3737
inputDir: 'docs',
3838
outputDir: '_site',
39-
outputDevDir: path.resolve('_site-dev'),
39+
outputDevDir: '_site-dev',
4040
build: {},
4141
devServer: {},
4242

packages/cli/src/public/rocketEleventyComputed.cjs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
const fs = require('fs');
2-
const path = require('path');
32
const { processContentWithTitle } = require('@rocket/core/title');
43
const { createPageSocialImage } = require('./createPageSocialImage.cjs');
54

@@ -36,7 +35,7 @@ module.exports = {
3635
if (data.page.filePathStem) {
3736
// filePathStem: '/sub/subsub/index'
3837
// filePathStem: '/index',
39-
const parts = data.page.filePathStem.split(path.sep);
38+
const parts = data.page.filePathStem.split('/');
4039
if (parts.length > 2) {
4140
return parts[1];
4241
}

packages/cli/test-node/RocketCli.e2e.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ describe('RocketCli e2e', () => {
215215
type: 'start',
216216
});
217217
expect(indexHtml).to.equal(
218-
'<p>You can show rocket config data like rocketConfig.absoluteBaseUrl = http://test-domain.com/</p>',
218+
'<p>You can show rocket config data like rocketConfig.absoluteBaseUrl = <a href="http://test-domain.com/">http://test-domain.com/</a></p>',
219219
);
220220
});
221221

0 commit comments

Comments
 (0)