Skip to content

Commit bd248dd

Browse files
committed
[storage] Fix checking both results in block device mirror
1 parent a489c10 commit bd248dd

File tree

2 files changed

+5
-25
lines changed

2 files changed

+5
-25
lines changed

src/modm/driver/storage/block_device_mirror.hpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,6 @@ class BdMirror : public modm::BlockDevice
112112
private:
113113
BlockDeviceA blockDeviceA;
114114
BlockDeviceB blockDeviceB;
115-
116-
private:
117-
bool resultA;
118-
bool resultB;
119-
120115
};
121116

122117
}

src/modm/driver/storage/block_device_mirror_impl.hpp

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,15 @@ template <typename BlockDeviceA, typename BlockDeviceB>
2121
bool
2222
modm::BdMirror<BlockDeviceA, BlockDeviceB>::initialize()
2323
{
24-
resultA = blockDeviceA.initialize();
25-
resultB = blockDeviceB.initialize();
26-
27-
return resultA && resultA;
24+
return blockDeviceA.initialize() and blockDeviceB.initialize();
2825
}
2926

3027
// ----------------------------------------------------------------------------
3128
template <typename BlockDeviceA, typename BlockDeviceB>
3229
bool
3330
modm::BdMirror<BlockDeviceA, BlockDeviceB>::deinitialize()
3431
{
35-
resultA = blockDeviceA.deinitialize();
36-
resultB = blockDeviceB.deinitialize();
37-
38-
return resultA && resultA;
32+
return blockDeviceA.deinitialize() and blockDeviceB.deinitialize();
3933
}
4034

4135
// ----------------------------------------------------------------------------
@@ -55,10 +49,7 @@ modm::BdMirror<BlockDeviceA, BlockDeviceB>::program(const uint8_t* buffer, bd_ad
5549
return false;
5650
}
5751

58-
resultA = blockDeviceA.program(buffer, address, size);
59-
resultB = blockDeviceB.program(buffer, address, size);
60-
61-
return resultA && resultA;
52+
return blockDeviceA.program(buffer, address, size) and blockDeviceB.program(buffer, address, size);
6253
}
6354

6455

@@ -71,10 +62,7 @@ modm::BdMirror<BlockDeviceA, BlockDeviceB>::erase(bd_address_t address, bd_size_
7162
return false;
7263
}
7364

74-
resultA = blockDeviceA.erase(address, size);
75-
resultB = blockDeviceB.erase(address, size);
76-
77-
return resultA && resultA;
65+
return blockDeviceA.erase(address, size) and blockDeviceB.erase(address, size);
7866
}
7967

8068

@@ -87,8 +75,5 @@ modm::BdMirror<BlockDeviceA, BlockDeviceB>::write(const uint8_t* buffer, bd_addr
8775
return false;
8876
}
8977

90-
resultA = blockDeviceA.write(buffer, address, size);
91-
resultB = blockDeviceB.write(buffer, address, size);
92-
93-
return resultA && resultA;
78+
return blockDeviceA.write(buffer, address, size) and blockDeviceB.write(buffer, address, size);
9479
}

0 commit comments

Comments
 (0)