implementation

Author: lantoli

internal/convert/clu2adv.go

@@ -107,6 +107,32 @@ func fillMovedBlocks(body *hclwrite.Body, moveLabels []string) {
 	}
 }
 
+// createDefaultReplicationSpec creates a default replication_specs for clusters without any
+// (e.g. upgraded from free tier).
+func createDefaultReplicationSpec(resourceb *hclwrite.Body, root attrVals) error {
+	resourceb.SetAttributeValue(nClusterType, cty.StringVal(valClusterType))
+	configb := hclwrite.NewEmptyFile().Body()
+	hcl.SetAttrInt(configb, nPriority, valMaxPriority)
+	if err := hcl.MoveAttr(resourceb, configb, nRegionNameSrc, nRegionName, errRoot); err != nil {
+		return err
+	}
+	if providerNameTokens, found := root.req[nProviderName]; found {
+		configb.SetAttributeRaw(nProviderName, providerNameTokens)
+	}
+
+	electableSpecb := hclwrite.NewEmptyFile().Body()
+	if instanceSizeTokens, found := root.req[nInstanceSizeSrc]; found {
+		electableSpecb.SetAttributeRaw(nInstanceSize, instanceSizeTokens)
+	}
+	electableSpecb.SetAttributeValue(nNodeCount, cty.NumberIntVal(valDefaultNodeCount))
+	configb.SetAttributeRaw(nElectableSpecs, hcl.TokensObject(electableSpecb))
+
+	repSpecsb := hclwrite.NewEmptyFile().Body()
+	repSpecsb.SetAttributeRaw(nConfig, hcl.TokensArraySingle(configb))
+	resourceb.SetAttributeRaw(nRepSpecs, hcl.TokensArraySingle(repSpecsb))
+	return nil
+}
+
 // fillFreeTierCluster is the entry point to convert clusters in free tier
 func processFreeTierCluster(resourceb *hclwrite.Body) error {
 	resourceb.SetAttributeValue(nClusterType, cty.StringVal(valClusterType))
@@ -160,7 +186,7 @@ func processRepSpecsCluster(resourceb *hclwrite.Body, root attrVals) error {
 	}
 	repSpecBlocks := collectBlocks(resourceb, nRepSpecs)
 	if len(repSpecBlocks) == 0 {
-		return fmt.Errorf("must have at least one replication_specs")
+		return createDefaultReplicationSpec(resourceb, root)
 	}
 	dConfig, err := processConfigsWithDynamicRegion(repSpecBlocks[0].Body(), root, false)
 	if err != nil {

internal/convert/const.go

@@ -1,20 +1,21 @@
 package convert
 
 const (
-	resourceType     = "resource"
-	dataSourceType   = "data"
-	cluster          = "mongodbatlas_cluster"
-	advCluster       = "mongodbatlas_advanced_cluster"
-	clusterPlural    = "mongodbatlas_clusters"
-	advClusterPlural = "mongodbatlas_advanced_clusters"
-	valClusterType   = "REPLICASET"
-	valMaxPriority   = 7
-	valMinPriority   = 0
-	errFreeCluster   = "free cluster (because no " + nRepSpecs + ")"
-	errRepSpecs      = "setting " + nRepSpecs
-	errPriority      = "setting " + nPriority
-	errNumShards     = "setting " + nNumShards
-	errRoot          = "setting root attributes"
+	resourceType        = "resource"
+	dataSourceType      = "data"
+	cluster             = "mongodbatlas_cluster"
+	advCluster          = "mongodbatlas_advanced_cluster"
+	clusterPlural       = "mongodbatlas_clusters"
+	advClusterPlural    = "mongodbatlas_advanced_clusters"
+	valClusterType      = "REPLICASET"
+	valMaxPriority      = 7
+	valMinPriority      = 0
+	valDefaultNodeCount = 3
+	errFreeCluster      = "free cluster (because no " + nRepSpecs + ")"
+	errRepSpecs         = "setting " + nRepSpecs
+	errPriority         = "setting " + nPriority
+	errNumShards        = "setting " + nNumShards
+	errRoot             = "setting root attributes"
 
 	commentGeneratedBy       = "Generated by atlas-cli-plugin-terraform."
 	commentConfirmReferences = "Please review the changes and confirm that references to this resource are updated."

internal/convert/testdata/clu2adv/free_cluster.out.tf

@@ -47,7 +47,9 @@ resource "mongodbatlas_advanced_cluster" "count" {
   # Please review the changes and confirm that references to this resource are updated.
 }
 
+
 resource "mongodbatlas_advanced_cluster" "upgrade_from_free_cluster" {
+  # upgraded free cluster to dedicated
   project_id   = var.project_id
   name         = var.cluster_name
   cluster_type = "REPLICASET"
@@ -60,6 +62,7 @@ resource "mongodbatlas_advanced_cluster" "upgrade_from_free_cluster" {
           provider_name = "AWS"
           electable_specs = {
             instance_size = "M10"
+            node_count    = 3
           }
         }
       ]
@@ -71,6 +74,7 @@ resource "mongodbatlas_advanced_cluster" "upgrade_from_free_cluster" {
 }
 
 resource "mongodbatlas_advanced_cluster" "upgrade_from_free_cluster_with_variables" {
+  # upgraded free cluster to dedicated, using variables in all attributes
   project_id   = var.project_id
   name         = var.cluster_name
   cluster_type = "REPLICASET"
@@ -83,6 +87,7 @@ resource "mongodbatlas_advanced_cluster" "upgrade_from_free_cluster_with_variabl
           provider_name = var.provider_name
           electable_specs = {
             instance_size = var.instance_size
+            node_count    = 3
           }
         }
       ]