deprecate some API that are no longer needed

Guest0x0 · Guest0x0 · commit e79747c8021e · 2025-09-26T15:11:23.000+08:00
diff --git a/examples/http_file_server/main.mbt b/examples/http_file_server/main.mbt
@@ -23,22 +23,16 @@ async fn serve_directory(
   conn
   ..send_response(200, "OK", extra_headers={ "Content-Type": "text/html" })
   ..write("<!DOCTYPE html><html><head></head><body>")
-  ..write_string("<h1>\{path}</h1>\n", encoding=UTF8)
+  ..write("<h1>\{path}</h1>\n")
   ..write("<div style=\"margin: 1em; font-size: 15pt\">")
-  ..write_string(
-    "<a href=\"\{path}?download_zip\">download as zip</a><br/><br/>\n",
-    encoding=UTF8,
-  )
+  ..write("<a href=\"\{path}?download_zip\">download as zip</a><br/><br/>\n")
   if path[:-1].rev_find("/") is Some(index) {
     let parent : StringView = if index == 0 { "/" } else { path[:index] }
-    conn.write_string("<a href=\"\{parent}\">..</a><br/><br/>\n", encoding=UTF8)
+    conn.write("<a href=\"\{parent}\">..</a><br/><br/>\n")
   }
   for file in files {
     let sep = if path[path.length() - 1] != '/' { "/" } else { "" }
-    conn.write_string(
-      "<a href=\"\{path}\{sep}\{file}\">\{file}</a><br/>\n",
-      encoding=UTF8,
-    )
+    conn.write("<a href=\"\{path}\{sep}\{file}\">\{file}</a><br/>\n")
   }
   conn..write("</div></body></html>")..end_response()
 }
diff --git a/examples/tcp_ping_pong/main.mbt b/examples/tcp_ping_pong/main.mbt
@@ -38,7 +38,7 @@ async fn server(println : Printer) -> Unit {
             let msg = buf.unsafe_reinterpret_as_bytes()[0:n]
             println("server received: \{@encoding/utf8.decode(msg)}")
             let reply = "pong"
-            conn.write_string(reply, encoding=UTF8)
+            conn.write(reply)
             println("server sent: \{reply}")
             if msg == b"exit" {
               println("server initiate terminate")
@@ -68,7 +68,7 @@ async fn client(println : Printer, id : Int, msg : String) -> Unit {
   // with server side "received connection" message
   @async.sleep(10)
   println("client \{id}: connection established")
-  conn.write_string(msg, encoding=UTF8)
+  conn.write(msg)
   println("client \{id} sent: \{msg}")
   let buf = FixedArray::make(1024, b'0')
   if conn.read(buf) is n && n > 0 {
diff --git a/src/fs/fs.mbt b/src/fs/fs.mbt
@@ -290,6 +290,7 @@ pub async fn read_file(path : String) -> &@io.Data {
 
 ///|
 /// Read the contents of a text file located at `path`.
+#deprecated("use `read_file(path).text()` instead")
 pub async fn read_text_file(path : String, encoding~ : @io.Encoding) -> String {
   guard encoding is UTF8
   read_file(path).text()
@@ -316,6 +317,7 @@ pub async fn write_file(
 /// Write data to a text file located at `path`.
 /// The meaning of `sync`, `append`, `create`, truncate` is the same as `open`,
 /// except that `truncate` is `true` by default. See `open` for more details.
+#deprecated("use `write_file(path, content)` instead")
 pub async fn write_text_file(
   path : String,
   content : String,
diff --git a/src/fs/pkg.generated.mbti b/src/fs/pkg.generated.mbti
@@ -26,6 +26,7 @@ fn opendir(String) -> Directory raise
 
 async fn read_file(String) -> &@io.Data
 
+#deprecated
 async fn read_text_file(String, encoding~ : @io.Encoding) -> String
 
 async fn readdir(String, include_hidden? : Bool, include_special? : Bool, sort? : Bool) -> Array[String]
@@ -38,6 +39,7 @@ async fn rmdir(String, recursive? : Bool) -> Unit
 
 async fn write_file(String, Bytes, sync? : SyncMode, append? : Bool, create? : Int, truncate? : Bool) -> Unit
 
+#deprecated
 async fn write_text_file(String, String, encoding~ : @io.Encoding, sync? : SyncMode, append? : Bool, create? : Int, truncate? : Bool) -> Unit
 
 // Errors
diff --git a/src/fs/text_file_test.mbt b/src/fs/text_file_test.mbt
@@ -17,7 +17,7 @@ async test "text file" {
   @async.with_task_group(fn(root) {
     let path = "basic_text_file_test"
     root.add_defer(() => @fs.remove(path))
-    @fs.write_text_file(path, "abcd", encoding=UTF8, create=0o644)
-    inspect(@fs.read_text_file(path, encoding=UTF8), content="abcd")
+    @fs.write_file(path, "abcd", create=0o644)
+    inspect(@fs.read_file(path).text(), content="abcd")
   })
 }
diff --git a/src/http/README.mbt.md b/src/http/README.mbt.md
@@ -82,7 +82,7 @@ pub async fn server(listen_addr : @socket.Addr) -> Unit {
           conn.skip_request_body()
           conn
           ..send_response(404, "NotFound")
-          ..write_string("`\{request.path}` not found", encoding=UTF8)
+          ..write("`\{request.path}` not found")
           ..end_response()
         }
       })
diff --git a/src/io/pkg.generated.mbti b/src/io/pkg.generated.mbti
@@ -50,6 +50,7 @@ pub(open) trait Writer {
   async write_once(Self, Bytes, offset~ : Int, len~ : Int) -> Int
   async write(Self, &Data) -> Unit = _
   async write_reader(Self, &Reader) -> Unit = _
+  #deprecated
   async write_string(Self, StringView, encoding~ : Encoding) -> Unit = _
 }
 
diff --git a/src/io/writer.mbt b/src/io/writer.mbt
@@ -22,6 +22,7 @@ pub(open) trait Writer {
   async write_once(Self, Bytes, offset~ : Int, len~ : Int) -> Int
   async write(Self, &Data) -> Unit = _
   async write_reader(Self, &Reader) -> Unit = _
+  #deprecated("use `write` instead")
   async write_string(Self, StringView, encoding~ : Encoding) -> Unit = _
 }
 
diff --git a/src/io/writer_test.mbt b/src/io/writer_test.mbt
@@ -113,7 +113,7 @@ async test "write_string" {
     defer r.close()
     root.spawn_bg(fn() {
       defer w.close()
-      w.write_string("abcd中文☺", encoding=UTF8)
+      w.write("abcd中文☺")
     })
     inspect(r.read_all().text(), content="abcd中文☺")
   })
diff --git a/src/missing_close_test.mbt b/src/missing_close_test.mbt
@@ -24,7 +24,7 @@ async test "missing_close" {
     })
     root.spawn_bg(fn() {
       let data = "abcd"
-      w.write_string(data, encoding=UTF8)
+      w.write(data)
       log.write_string("written \{data}\n")
     })
   })

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ pub async fn server(listen_addr : @socket.Addr) -> Unit {`
`82`	`82`	`conn.skip_request_body()`
`83`	`83`	`conn`
`84`	`84`	`..send_response(404, "NotFound")`
`85`		- ..write_string("`\{request.path}` not found", encoding=UTF8)
	`85`	+ ..write("`\{request.path}` not found")
`86`	`86`	`..end_response()`
`87`	`87`	`}`
`88`	`88`	`})`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ pub(open) trait Writer {`
`50`	`50`	`async write_once(Self, Bytes, offset~ : Int, len~ : Int) -> Int`
`51`	`51`	`async write(Self, &Data) -> Unit = _`
`52`	`52`	`async write_reader(Self, &Reader) -> Unit = _`
	`53`	`+ #deprecated`
`53`	`54`	`async write_string(Self, StringView, encoding~ : Encoding) -> Unit = _`
`54`	`55`	`}`
`55`	`56`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ pub(open) trait Writer {`
`22`	`22`	`async write_once(Self, Bytes, offset~ : Int, len~ : Int) -> Int`
`23`	`23`	`async write(Self, &Data) -> Unit = _`
`24`	`24`	`async write_reader(Self, &Reader) -> Unit = _`
	`25`	+ #deprecated("use `write` instead")
`25`	`26`	`async write_string(Self, StringView, encoding~ : Encoding) -> Unit = _`
`26`	`27`	`}`
`27`	`28`