Issue #110: Bug fix: Do not try to load URL if empty

Author: csadilek

components/feature/session/src/main/java/mozilla/components/feature/session/SessionIntentProcessor.kt

@@ -20,11 +20,12 @@ class SessionIntentProcessor(
         val url = intent.dataString
         if (TextUtils.isEmpty(url)) {
             false
+        } else {
+            // TODO switch to loadUrlInNewTab
+            // https://github.com/mozilla-mobile/android-components/issues/136
+            sessionUseCases.loadUrl.invoke(url)
+            true
         }
-
-        // TODO switch to loadUrlInNewTab, once available
-        sessionUseCases.loadUrl.invoke(url)
-        true
     }
 
     private val defaultHandlers: MutableMap<String, IntentHandler> by lazy {

components/feature/session/src/test/java/mozilla/components/feature/session/SessionIntentProcessorTest.kt

@@ -15,6 +15,7 @@ import org.junit.Test
 import org.junit.runner.RunWith
 import org.mockito.Mockito.`when`
 import org.mockito.Mockito.mock
+import org.mockito.Mockito.never
 import org.mockito.Mockito.verify
 import org.mockito.Mockito.verifyZeroInteractions
 import org.robolectric.RobolectricTestRunner
@@ -33,12 +34,16 @@ class SessionIntentProcessorTest {
     }
 
     @Test
-    fun testProcessWIthDefaultHandlers() {
+    fun testProcessWithDefaultHandlers() {
         val handler = SessionIntentProcessor(useCases)
         val intent = mock(Intent::class.java)
         `when`(intent.action).thenReturn(Intent.ACTION_VIEW)
-        `when`(intent.dataString).thenReturn("http://mozilla.org")
 
+        `when`(intent.dataString).thenReturn("")
+        handler.process(intent)
+        verify(engineSession, never()).loadUrl("")
+
+        `when`(intent.dataString).thenReturn("http://mozilla.org")
         handler.process(intent)
         verify(engineSession).loadUrl("http://mozilla.org")
     }