set the defined state for all elements

Author: mukilan

components/script/dom/bindings/constructor.rs

@@ -183,7 +183,7 @@ fn html_constructor(
                     &document,
                     ElementCreator::ScriptCreated,
                     None,
-                    false
+                    false,
                 )
             };
 

components/script/dom/create.rs

@@ -237,7 +237,8 @@ fn create_html_element(
     // custom element state set to "uncustomized", custom element definition set to null,
     // is value set to is, and node document set to document.
     let is_builtin = is.is_none() && !is_valid_custom_element_name(&name.local);
-    let result = create_native_html_element(name.clone(), prefix, document, creator, proto, is_builtin);
+    let result =
+        create_native_html_element(name.clone(), prefix, document, creator, proto, is_builtin);
     // Step 5.3. If namespace is the HTML namespace, and either localName is a valid custom element name or
     // is is non-null, then set result’s custom element state to "undefined".
     match is {
@@ -280,7 +281,7 @@ pub(crate) fn create_native_html_element(
     // This is a big match, and the IDs for inline-interned atoms are not very structured.
     // Perhaps we should build a perfect hash from those IDs instead.
     // https://html.spec.whatwg.org/multipage/#elements-in-the-dom
-    match name.local {
+    let element: DomRoot<Element> = match name.local {
         local_name!("a") => make!(HTMLAnchorElement),
         local_name!("abbr") => make!(HTMLElement),
         local_name!("acronym") => make!(HTMLElement),
@@ -318,14 +319,7 @@ pub(crate) fn create_native_html_element(
         local_name!("dfn") => make!(HTMLElement),
         local_name!("dialog") => make!(HTMLDialogElement),
         local_name!("dir") => make!(HTMLDirectoryElement),
-        local_name!("div") => {
-            let obj = if defined {
-                HTMLDivElement::new_defined(name.local, prefix, document, proto, CanGc::note())
-            } else {
-                HTMLDivElement::new(name.local, prefix, document, proto, CanGc::note())
-            };
-            DomRoot::upcast(obj)
-        },
+        local_name!("div") => make!(HTMLDivElement),
         local_name!("dl") => make!(HTMLDListElement),
         local_name!("dt") => make!(HTMLElement),
         local_name!("em") => make!(HTMLElement),
@@ -435,7 +429,13 @@ pub(crate) fn create_native_html_element(
         local_name!("xmp") => make!(HTMLPreElement),
         _ if is_valid_custom_element_name(&name.local) => make!(HTMLElement),
         _ => make!(HTMLUnknownElement),
+    };
+
+    if defined {
+        element.force_defined();
     }
+
+    element
 }
 
 pub(crate) fn create_element(

components/script/dom/element.rs

@@ -4959,6 +4959,13 @@ impl Element {
         self.state.get()
     }
 
+    pub(crate) fn force_defined(&self) {
+        let mut state = self.state.get();
+        state.insert(ElementState::DEFINED);
+        // debug_assert!(state == ElementState::ENABLED || state == ElementState::empty());
+        self.state.set(state);
+    }
+
     pub(crate) fn set_state(&self, which: ElementState, value: bool) {
         let mut state = self.state.get();
         let previous_state = state;

components/script/dom/htmldivelement.rs

@@ -5,7 +5,6 @@
 use dom_struct::dom_struct;
 use html5ever::{LocalName, Prefix};
 use js::rust::HandleObject;
-use stylo_dom::ElementState;
 
 use crate::dom::bindings::codegen::Bindings::HTMLDivElementBinding::HTMLDivElementMethods;
 use crate::dom::bindings::root::DomRoot;
@@ -31,29 +30,6 @@ impl HTMLDivElement {
         }
     }
 
-    #[cfg_attr(crown, allow(crown::unrooted_must_root))]
-    pub(crate) fn new_defined(
-        local_name: LocalName,
-        prefix: Option<Prefix>,
-        document: &Document,
-        proto: Option<HandleObject>,
-        can_gc: CanGc,
-    ) -> DomRoot<HTMLDivElement> {
-        Node::reflect_node_with_proto(
-            Box::new(HTMLDivElement {
-                htmlelement: HTMLElement::new_inherited_with_state(
-                    ElementState::DEFINED,
-                    local_name,
-                    prefix,
-                    document
-                )
-            }),
-            document,
-            proto,
-            can_gc,
-        )
-    }
-
     #[cfg_attr(crown, allow(crown::unrooted_must_root))]
     pub(crate) fn new(
         local_name: LocalName,