Skip to content

fix: Do not allow sharing . #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

fix: Do not allow sharing . #105

merged 2 commits into from
Sep 17, 2025

Conversation

@rklaehn
Copy link
Collaborator

@rklaehn rklaehn commented Sep 17, 2025 •
edited
Loading

We create a temp dir in ., and it will be changing over time. We could filter it out, but that's a can of worms. So for now just forbid sharing .

Fixes #96

@rklaehn
Do not allow sharing .
9fab403 
We create a temp dir in ., and it will be changing over time.
We could filter it out, but that's a can of worms. So for now just forbid
sharing .
@rklaehn
Add comment about . limitation
8149ef9
@rklaehn rklaehn merged commit 91d2185 into main Sep 17, 2025
@rklaehn rklaehn deleted the forbid-sharing-dot branch September 17, 2025 08:34
@vt-alt
Copy link

vt-alt commented Sep 17, 2025

Thanks!

@Jisu-Woniu
Copy link
Contributor

I suggest never create temp dirs in ., instead create it in global temp dirs like /tmp, /var/tmp, or %USERPROFILE%\AppData\Local\Temp. It is less likely for a user to send such directories instead of . / $PWD. Crates like tempfile may help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sendme send . results in generic error: LeafNotFound(0) ... Hash not found

4 participants

@rklaehn @vt-alt @Jisu-Woniu