Skip to content

Commit b292fe6

Browse files
committed
Fix #2478, Add missing deafult/break to switch statements
1 parent 37f1d28 commit b292fe6

File tree

23 files changed

+60
-32
lines changed

23 files changed

+60
-32
lines changed

.github/workflows/code-coverage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ jobs:
104104
105105
- name: Confirm Minimum Coverage
106106
run: |
107-
missed_branches=52
108-
missed_lines=18
107+
missed_branches=50
108+
missed_lines=40
109109
branch_nums=$(grep -A 3 "Overall coverage rate" lcov_out.txt | grep branches | grep -oP "[0-9]+[0-9]*")
110110
line_nums=$(grep -A 3 "Overall coverage rate" lcov_out.txt | grep lines | grep -oP "[0-9]+[0-9]*")
111111

.github/workflows/codeql-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
jobs:
1212
codeql:
1313
uses: nasa/cFS/.github/workflows/codeql-reusable.yml@main
14-
with:
14+
with:
1515
component-path: cfe
1616
make: make -j8
1717
test: true

.github/workflows/icbundle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
done
6060
changelog_entry="${changelog_entry}\n${see_entry}\n"
6161
sed -ir "s|# Changelog|$changelog_entry|" CHANGELOG.md
62-
62+
6363
buildnumber_entry=$'#define CFE_BUILD_NUMBER '${rev_num}$' /**< @brief Development: Number of development git commits since CFE_BUILD_BASELINE */'
6464
sed -ir "s|#define CFE_BUILD_NUMBER.*|$buildnumber_entry|" modules/core_api/fsw/inc/cfe_version.h
6565
- name: Commit and Push Updates to IC Branch

docs/cFS_IdentifierNamingConvention.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ Common command/event descriptions include:
247247
| `LEN_ERR` | Incorrect Message Length | Error |
248248
| `CC_ERR` | Invalid Command Code Received | Error |
249249
| `NOOP_INF` | No-op Command Success | Informational |
250-
| `INIT_INF` | Applicaiton Initialization Success | Informational |
250+
| `INIT_INF` | Application Initialization Success | Informational |
251251
| `RESET_INF` | Reset Command Counters Command Success | Informational |
252252

253253
# Appendix: Abbreviation Guide

modules/cfe_assert/src/cfe_assert_runner.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ bool CFE_Assert_Status_DeferredCheck(CFE_Status_t Status, UtAssert_CaseType_t Ca
138138
}
139139
else
140140
{
141-
/* if condition was false add an exta marker so user does not necessarily need to decode the string */
141+
/* if condition was false add an extra marker so user does not necessarily need to decode the string */
142142
ExtraTag = " [false]";
143143
}
144144

modules/cfe_testcase/src/cfe_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ void CFE_TestMain(void)
5858
* Register test cases in UtAssert
5959
*/
6060
ESApplicationControlTestSetup();
61-
ESBehaviorestSetup();
61+
ESBehaviorTestSetup();
6262
ESCDSTestSetup();
6363
ESCounterTestSetup();
6464
ESErrorTestSetup();

modules/cfe_testcase/src/cfe_test.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ void TimeInRange(CFE_TIME_SysTime_t Start, CFE_TIME_SysTime_t Time, CFE_TIME_Sys
7272

7373
void CFE_TestMain(void);
7474
void ESApplicationControlTestSetup(void);
75-
void ESBehaviorestSetup(void);
75+
void ESBehaviorTestSetup(void);
7676
void ESCDSTestSetup(void);
7777
void ESCounterTestSetup(void);
7878
void ESErrorTestSetup(void);

modules/cfe_testcase/src/es_behavior_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ void TestWaitBehavior(void)
8282
UtAssert_UINT32_EQ(CFE_TIME_Compare(TimePassed, TimeExpected), CFE_TIME_A_LT_B);
8383
}
8484

85-
void ESBehaviorestSetup(void)
85+
void ESBehaviorTestSetup(void)
8686
{
8787
UtTest_Add(TestRunCounter, NULL, NULL, "Test Run Counter");
8888
UtTest_Add(TestWaitBehavior, NULL, NULL, "Test Wait Behavior");

modules/cfe_testcase/src/sb_pipe_mang_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void TestPipeCreateMax(void)
7474
* Normally, this will return CFE_SUCCESS, until the max number of pipes is reached.
7575
* Confirm that the last creation attempt returned CFE_SB_MAX_PIPES_MET
7676
*
77-
* NOTE: this also mimics the same format as UtAssert_INT32_EQ so that any post-procesing
77+
* NOTE: this also mimics the same format as UtAssert_INT32_EQ so that any post-processing
7878
* test log analysis tools will see this call as well.
7979
*/
8080
if (CFE_Assert_STATUS_MAY_BE(CFE_SB_MAX_PIPES_MET))

modules/cfe_testcase/tables/cfe_test_tbl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
/*
3232
* The test table data should contain some identifiable numeric values,
33-
* so any issues with paritial loading/byteswapping are morely likely
33+
* so any issues with partial loading/byteswapping are more likely
3434
* to be detected.
3535
*/
3636
CFE_TEST_TestTable_t TestTable = {0xf007, 0xba11};

0 commit comments

Comments
 (0)