Skip to content

Commit 79604ee

Browse files
author
Mario Blazek
committed
We do not need config resolver any more, configuration injected directly
1 parent 14d0f42 commit 79604ee

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

bundle/Factory/EmailDataFactory.php

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
class EmailDataFactory
1313
{
1414
/**
15-
* @var ConfigResolverInterface
15+
* @var array
1616
*/
17-
protected $configResolver;
17+
protected $config;
1818

1919
/**
2020
* @var TranslationHelper
@@ -34,19 +34,19 @@ class EmailDataFactory
3434
/**
3535
* EmailDataFactory constructor.
3636
*
37-
* @param ConfigResolverInterface $configResolver
37+
* @param array $config
3838
* @param TranslationHelper $translationHelper
3939
* @param FieldHelper $fieldHelper
4040
* @param ContentTypeService $contentTypeService
4141
*/
4242
public function __construct(
43-
ConfigResolverInterface $configResolver,
43+
array $config,
4444
TranslationHelper $translationHelper,
4545
FieldHelper $fieldHelper,
4646
ContentTypeService $contentTypeService
4747
) {
4848

49-
$this->configResolver = $configResolver;
49+
$this->config = $config;
5050
$this->translationHelper = $translationHelper;
5151
$this->fieldHelper = $fieldHelper;
5252
$this->contentTypeService = $contentTypeService;
@@ -87,7 +87,7 @@ protected function resolve(Content $content, $field, $property = 'text')
8787

8888
return $fieldValue->value->$property;
8989
} else {
90-
return $this->configResolver->getParameter('information_collection.email.' . $field, 'netgen');
90+
return $this->config['default_variables'][$field];
9191
}
9292
}
9393

@@ -104,10 +104,12 @@ protected function resolveTemplate($content)
104104

105105
$contentTypeIdentifier = $contentType->identifier;
106106

107-
if ($this->configResolver->hasParameter('information_collection.email.' . $contentTypeIdentifier, 'netgen')) {
108-
return $this->configResolver->getParameter('information_collection.email.' . $contentTypeIdentifier, 'netgen');
107+
if (array_key_exists($contentTypeIdentifier, $this->config['templates'])) {
108+
109+
return $this->config['templates'][$contentTypeIdentifier];
110+
109111
}
110112

111-
return $this->configResolver->getParameter('information_collection.email.default', 'netgen');
113+
return $this->config['templates']['default'];
112114
}
113115
}

bundle/Resources/config/services.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ services:
5151
netgen_information_collection.factory.email_data:
5252
class: '%netgen_information_collection.factory.email_data.class%'
5353
arguments:
54-
- '@ezpublish.config.resolver'
54+
- "$action_config.email;netgen_information_collection$"
5555
- '@ezpublish.translation_helper'
5656
- '@ezpublish.field_helper'
5757
- '@ezpublish.api.service.content_type'

0 commit comments

Comments
 (0)