-
Notifications
You must be signed in to change notification settings - Fork 108
enh/y indexeddb #7621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
max-nextcloud
wants to merge
11
commits into
main
Choose a base branch
from
enh/y-indexeddb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
enh/y indexeddb #7621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7621 +/- ##
==========================================
- Coverage 47.06% 46.98% -0.09%
==========================================
Files 141 141
Lines 3886 3893 +7
Branches 733 735 +2
==========================================
Hits 1829 1829
- Misses 1763 1768 +5
- Partials 294 296 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
15aff59 to
9b4afdb
Compare
9b4afdb to
d43a2a7
Compare
d43a2a7 to
f52166a
Compare
6637691 to
e746625
Compare
For now text is sometimes duplicated Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Keep the baseVersionEtag and the editing session around in case people who are offline connect again later. Signed-off-by: Max <[email protected]>
... and use it to check if the server is still on the same session. Signed-off-by: Max <[email protected]>
When reopening a document that was edited offline it will also be considered dirty now. Autosave will not kick in yet... As no steps are pushed. But when closing the file it will be saved. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
…Step Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
If no changes have been made offline clear the indexedDb cache and reload Editor.vue to load the latest editing session from the server. Signed-off-by: Max <[email protected]>
e746625 to
62c82f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
base_version_etagas custom property to IndexedDBbaseVersionEtagas part of create requestbaseVersionEtag.