Skip to content

Commit 98a2d5c

Browse files
fr3nch13thde
authored andcommitted
Add ssl options for faraday
1 parent 8d0dbae commit 98a2d5c

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ NetboxClientRuby.configure do |config|
4747
config.netbox.auth.rsa_private_key.password = ''
4848
config.netbox.pagination.default_limit = 50
4949
config.faraday.adapter = Faraday.default_adapter
50+
# https://lostisland.github.io/faraday/#/customization/request-options
5051
config.faraday.request_options = { open_timeout: 1, timeout: 5 }
52+
# see: https://lostisland.github.io/faraday/#/customization/ssl-options
53+
config.faraday.ssl_options = { verify: true }
5154
config.faraday.logger = :logger # built-in options: :logger, :detailed_logger; default: nil
5255
end
5356
```

lib/netbox_client_ruby.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ module NetboxClientRuby
6565
setting :adapter, default: :net_http
6666
setting :logger
6767
setting :request_options, default: { open_timeout: 1, timeout: 5 }
68+
setting :ssl_options, default: { verify: true }
6869
end
6970

7071
def self.circuits

lib/netbox_client_ruby/connection.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def self.netbox_config
2828

2929
private_class_method def self.build_faraday(request_encoding: :json)
3030
config = NetboxClientRuby.config
31-
Faraday.new(url: config.netbox.api_base_url, headers: headers) do |faraday|
31+
Faraday.new(url: config.netbox.api_base_url, headers: headers, ssl: config.faraday.ssl_options) do |faraday|
3232
faraday.request request_encoding
3333
faraday.response config.faraday.logger if config.faraday.logger
3434
faraday.response :json, content_type: /\bjson$/

spec/netbox_client_ruby/netbox_spec.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
config.faraday.adapter = :net_http_persistent
1515
config.faraday.logger = :detailed_logger
1616
config.faraday.request_options = { open_timeout: 3, timeout: 15 }
17+
config.faraday.ssl_options = { verify: true }
1718
end
1819

1920
expect(NetboxClientRuby.config.netbox.auth.token)
@@ -34,6 +35,8 @@
3435
.to be :detailed_logger
3536
expect(NetboxClientRuby.config.faraday.request_options)
3637
.to eq(open_timeout: 3, timeout: 15)
38+
expect(NetboxClientRuby.config.faraday.ssl_options)
39+
.to eq(verify: true)
3740
end
3841

3942
{

0 commit comments

Comments
 (0)