Skip to content

Commit 83c955d

Browse files
authored
src: add name for more threads
PR-URL: #59601 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
1 parent c86c488 commit 83c955d

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

src/node_platform.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ class WorkerThreadsTaskRunner::DelayedTaskScheduler {
101101

102102
std::unique_ptr<uv_thread_t> Start() {
103103
auto start_thread = [](void* data) {
104+
uv_thread_setname("DelayedTaskSchedulerWorker");
104105
static_cast<DelayedTaskScheduler*>(data)->Run();
105106
};
106107
std::unique_ptr<uv_thread_t> t { new uv_thread_t() };

src/node_watchdog.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ Watchdog::~Watchdog() {
8080

8181

8282
void Watchdog::Run(void* arg) {
83+
uv_thread_setname("Watchdog");
8384
Watchdog* wd = static_cast<Watchdog*>(arg);
8485

8586
// UV_RUN_DEFAULT the loop will be stopped either by the async or the
@@ -229,9 +230,9 @@ void TraceSigintWatchdog::HandleInterrupt() {
229230

230231
#ifdef __POSIX__
231232
void* SigintWatchdogHelper::RunSigintWatchdog(void* arg) {
233+
uv_thread_setname("SigintWatchdog");
232234
// Inside the helper thread.
233235
bool is_stopping;
234-
235236
do {
236237
uv_sem_wait(&instance.sem_);
237238
is_stopping = InformWatchdogsAboutSignal();

src/tracing/agent.cc

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,15 @@ void Agent::Start() {
9494
// This thread should be created *after* async handles are created
9595
// (within NodeTraceWriter and NodeTraceBuffer constructors).
9696
// Otherwise the thread could shut down prematurely.
97-
CHECK_EQ(0, uv_thread_create(&thread_, [](void* arg) {
98-
Agent* agent = static_cast<Agent*>(arg);
99-
uv_run(&agent->tracing_loop_, UV_RUN_DEFAULT);
100-
}, this));
97+
CHECK_EQ(0,
98+
uv_thread_create(
99+
&thread_,
100+
[](void* arg) {
101+
uv_thread_setname("TraceEventWorker");
102+
Agent* agent = static_cast<Agent*>(arg);
103+
uv_run(&agent->tracing_loop_, UV_RUN_DEFAULT);
104+
},
105+
this));
101106
started_ = true;
102107
}
103108

0 commit comments

Comments
 (0)