How open buffer always in new tab for lsp_finder

[Fedex159]

Hello, I have one question, I want to know how can I made, when I am in lsp_finder and I have a function where has 2 o more reference, every time I open one, is always replacing the tab where was originaly open. I want to know if there is possible to open always in a new tab.

Actual behavior:

Expected behavior:

Video:

finder_new_tab_always.mp4

[glepnir]

can add a tbnew action for it

[Fedex159]

can add a tbnew action for it

Yes, that can be very helpful !! 😃

[glepnir]

create an issue for this .

[glepnir]

no need now. I had supported it . finder.keys.tabnew

[Fedex159]

Hi @glepnir , I trying the last changes but is not working, is open the tab but always replace the tab.

finder_new_tab_error.mp4

[glepnir]

can't reproduce

[Fedex159]

Ok, I tryed with this minimal.lua

local test_dir = "/tmp/lspsaga"
local root = vim.fn.fnamemodify(test_dir, ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- base settings
vim.cmd('autocmd!')

vim.wo.number = true
vim.opt.relativenumber = true
vim.opt.showtabline = 2

-- keymaps
vim.keymap.set('n', 'gd', '<Cmd>Lspsaga lsp_finder<cr>', { noremap = true, silent = true })
vim.keymap.set("n", "K", "<cmd>Lspsaga hover_doc<CR>")
vim.keymap.set('n', '<leader>c', ':noh<CR>', { silent = true })
vim.api.nvim_set_keymap('n', '<Tab>', 'gt', {})
vim.api.nvim_set_keymap('n', '<S-Tab>', 'gT', {})


-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  -- lspconfig
  {
    'neovim/nvim-lspconfig',
    lazy = false,
  },
  -- mason
  {
    'williamboman/mason-lspconfig.nvim',
    lazy = false,
  },
  {
    'williamboman/mason.nvim',
    lazy = false,
  },
  -- lspsaga
  {
    "glepnir/lspsaga.nvim",
    event = "BufRead",
    config = function()
      require("lspsaga").setup({
        ui = {
          winblend = 10,
          border = 'rounded',
        }
      })
    end,
    dependencies = {
      { "nvim-tree/nvim-web-devicons" },
      { "nvim-treesitter/nvim-treesitter", build = ":TSUpdate" },
    },
    lazy = false,
  },
  -- theme
  {
    "Shatur/neovim-ayu",
    lazy = false,
  }
}


require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

-- setup lspconfig
local statusLsp, lspconfig = pcall(require, "lspconfig");

if statusLsp then
  lspconfig.tsserver.setup {
    filetypes = {
      "javascript",
      "javascriptreact",
      "javascript.jsx",
      "typescript",
      "typescriptreact",
      "typescript.tsx"
    },
    cmd = { "typescript-language-server", "--stdio" },
  }
  lspconfig.lua_ls.setup {
    settings = {
      Lua = {
        diagnostics = {
          -- Get the language server to recognize the `vim` global
          globals = { 'vim' },
        },
        workspace = {
          -- Make the server aware of Neovim runtime files
          library = vim.api.nvim_get_runtime_file("", true),
          checkThirdParty = false,

        },
      },
    },
  }
end

-- setup treesitter
local ok, treesitter = pcall(require, "nvim-treesitter.configs")
if ok then
  treesitter.setup({
    ensure_installed = {
      "tsx",
      "json",
      "css",
      "html",
      "lua",
      "typescript",
      "javascript",
      "markdown",
      "markdown_inline"
    },
    highlight = { enable = true },
  })
end

-- setup ayu
local statusAyu, ayu = pcall(require, "ayu")
if statusAyu then
  ayu.setup({
    mirage = true,
  })
  ayu.colorscheme()
end

require('mason').setup({
  ui = {
    icons = {
      package_installed = "✓",
      package_pending = "➜",
      package_uninstalled = "✗"
    }
  }
})


require('mason-lspconfig').setup({
  ensure_installed = { "lua_ls", "tsserver" },
  automatic_installation = true
})

and with this fail:

• Open the neovim with the minimal.lua
• Wait all the installs, close and open again
• Go to line where say require("lspsaga").setup({
• Press gd
• Down to lazy/core/cache.lua and press r
• Press Tab or gt to back to the previous tab
• Press gd again over require and down to /lazy/core/config.lua
• Press r and now the tab where was open cache.lua is gone

Here a video

error_using_minimal.mp4

Can you say if that flow works fine in your machine?. Thanks

[glepnir]

I don't called this config to mean..

vim.opt.runtimepath:append('path/to/nvim-lspconfig')
vim.opt.runtimepath:append('path/to/lspsaga.nvim')
local lspconfig = require('lspconfig')
lspconfig.lua_ls.setup({
  settings = {
    Lua = {
      workspace = {
        library = {
          vim.env.VIMRUNTIME,
        },
        checkThirdParty = false,
      },
    },
  },
})

require('lspaga').setup({})
vim.keymap.set('n', 'gh', '<cmd>Lspsaga lsp_finder<CR>')

[Fedex159]

What ypu say with:

I don't called this config to mean..

I am getting this error:

Sorry for make questions, but I my native language is Spanish and is difficult to understand for me.

Can you send me your final minimal.lua please?. Thanks

[Fedex159]

Well, I found at least where is failing in my code.

I commented this line in this function and is works

function finder:clean_data()
  for _, buf in pairs(self.wipe_buffers or {}) do
    --[[ api.nvim_buf_delete(buf, { force = true }) ]]
    pcall(vim.keymap.del, 'n', config.finder.keys.close_in_preview, { buffer = buf })
  end

  if self.group then
    pcall(api.nvim_del_augroup_by_id, self.group)
  end
end

but, now is not showing the line numbers in the new buffers

If I can solved that, is ready.

[glepnir]

how to reproduce ? create an issue should be fine.