Skip to content

Commit c0643eb

Browse files
author
Marti Wong
committed
Use new folder icon in folder picker when new bookmark flag is on.
Bug: 774651 Change-Id: I91c3120212926bb76e95517874f992ceb04d5359 Reviewed-on: https://chromium-review.googlesource.com/722360 Commit-Queue: Sylvain Defresne <[email protected]> Reviewed-by: Sylvain Defresne <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#509393}(cherry picked from commit 02dc512) Reviewed-on: https://chromium-review.googlesource.com/727441 Reviewed-by: Marti Wong <[email protected]> Cr-Commit-Position: refs/branch-heads/3239@{#61} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
1 parent b050aad commit c0643eb

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
#import "ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.h"
66

7+
#include "ios/chrome/browser/bookmarks/bookmark_new_generation_features.h"
78
#import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
89
#import "ios/chrome/browser/ui/rtl_geometry.h"
910
#include "ios/chrome/grit/ios_strings.h"
@@ -42,7 +43,8 @@ + (instancetype)folderCell {
4243
[[[self class] alloc] initWithStyle:UITableViewCellStyleDefault
4344
reuseIdentifier:[self folderCellReuseIdentifier]];
4445
folderCell.indentationWidth = kFolderCellIndentationWidth;
45-
folderCell.imageView.image = [UIImage imageNamed:@"bookmark_gray_folder"];
46+
folderCell.imageView.image =
47+
[UIImage imageNamed:[[self class] bookmarkFolderImageName]];
4648
return folderCell;
4749
}
4850

@@ -65,7 +67,8 @@ - (instancetype)initWithStyle:(UITableViewCellStyle)style
6567
self.textLabel.font = [MDCTypography subheadFont];
6668
self.textLabel.textColor = bookmark_utils_ios::darkTextColor();
6769
self.selectionStyle = UITableViewCellSelectionStyleGray;
68-
self.imageView.image = [UIImage imageNamed:@"bookmark_gray_folder"];
70+
self.imageView.image =
71+
[UIImage imageNamed:[[self class] bookmarkFolderImageName]];
6972
self.accessibilityTraits |= UIAccessibilityTraitButton;
7073
_enabled = YES;
7174
}
@@ -113,4 +116,15 @@ - (void)prepareForReuse {
113116
self.enabled = YES;
114117
}
115118

119+
#pragma mark - Private
120+
121+
// TODO(crbug.com/695749): Remove this function and use bookmark_gray_folder
122+
// only when the new folder picker (and its folder cell class) is created for
123+
// the new ui.
124+
+ (NSString*)bookmarkFolderImageName {
125+
return (base::FeatureList::IsEnabled(kBookmarkNewGeneration))
126+
? @"bookmark_gray_folder_new"
127+
: @"bookmark_gray_folder";
128+
}
129+
116130
@end

0 commit comments

Comments
 (0)