Skip to content

Commit eb4dca4

Browse files
Updated deps and linting
1 parent 2efb438 commit eb4dca4

File tree

7 files changed

+980
-631
lines changed

7 files changed

+980
-631
lines changed

.eslintrc.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
module.exports = {
77
parser: '@babel/eslint-parser',
88
parserOptions: {
9-
ecmaVersion: 2017,
9+
ecmaVersion: 2022,
1010
requireConfigFile: false
1111
},
1212
env: {
@@ -18,5 +18,10 @@ module.exports = {
1818
'tjw-base',
1919
'tjw-jest',
2020
'tjw-jsdoc'
21-
]
21+
],
22+
rules: {
23+
// Turn on after https://github.com/eslint/eslint/issues/14745 resolved
24+
'jsdoc/check-examples': 0,
25+
'jsdoc/require-example': 1
26+
}
2227
};

.github/workflows/node.js.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
matrix:
1919
os: [macos-latest, windows-latest, ubuntu-latest]
20-
node-version: [8.3.0, 14.x]
20+
node-version: [8.3.0, 18.x]
2121

2222
steps:
2323
- uses: actions/checkout@v2
@@ -28,17 +28,17 @@ jobs:
2828

2929
# Node 8.3.0 comes with npm 5.3.0.
3030
# npm 5.7.1 is the first version to support npm ci
31-
- if: ${{ matrix.node-version != '14.x' }}
31+
- if: ${{ matrix.node-version != '18.x' }}
3232
run: npm install -g [email protected]
3333

3434
- run: npm ci
3535
- run: npm run e2e
3636

3737
# mock-fs dropped support for Node 10
38-
- if: ${{ matrix.node-version == '14.x' }}
38+
- if: ${{ matrix.node-version == '18.x' }}
3939
run: npm t
4040

41-
# ESLint 7.x uses `} catch {` which isn't supported in Node 8
42-
- if: ${{ matrix.node-version == '14.x' }}
41+
# ESLint 7+ uses `} catch {` which isn't supported in Node 8
42+
- if: ${{ matrix.node-version == '18.x' }}
4343
run: npm run lint
4444

README.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -217,16 +217,16 @@ In Windows 8+ it might be possible to pin a "tile" in the start menu, but that l
217217
**End-to-end tests run on every commit using:**
218218

219219
* Ubuntu latest with Node v8.3.0
220-
* Ubuntu latest with Node v14.x.x
220+
* Ubuntu latest with Node v18.x.x
221221
* Windows latest with Node v8.3.0
222-
* Windows latest with Node v14.x.x
222+
* Windows latest with Node v18.x.x
223223
* OSX latest with Node v8.3.0
224-
* OSX latest with Node v14.x.x
224+
* OSX latest with Node v18.x.x
225225

226226
**Manually Tested on:**
227227

228228
* Windows XP with Node v4.4.5
229-
* Windows 7 with Node v4.0.0, v8, v10, v12
229+
* Windows 7 with Node v4.0.0, v8, v10, v12, v13.13.0 (last supported Node version for Win 7)
230230
* Windows 10 with Node v12, v14, v15
231231
* Ubuntu 16, 20 with Node v12
232232
* OSX 10.11 with Node v7.3.0
@@ -263,10 +263,8 @@ Parts of the `windows.vbs` were copied/modified based on:
263263
## Running locally for development
264264

265265
1. Pick and install a Node version manager
266+
* Win 7+/Lin/OSX - [Volta](https://volta.sh)
266267
* Linux/OSX - [nvm](https://github.com/nvm-sh/nvm)
267-
* Windows 8+ - [nvm-windows](https://github.com/coreybutler/nvm-windows)
268-
* Windows 7 - [nodist](https://github.com/nullivex/nodist)
269-
* Win/Lin/OSX - [volta](https://volta.sh/)
270268
1. Use the above tool to install Node (14+) (comes with npm)
271269
1. Fork/Clone the repo with `git`
272270
1. `npm install`

0 commit comments

Comments
 (0)