Skip to content

Conversation

Copy link

Copilot AI commented Jul 10, 2025

This PR adds a new term "episcleral vein" to the UBERON ontology as requested in issue #1680.

New Term Details

UBERON:7770011 - episcleral vein

  • Definition: "A vein located between the bulbar conjunctiva and the sclera."
  • Parent class: UBERON:0009141 (craniocervical region vein)
  • Part of: UBERON:0010292 (episcleral layer of eyeball)
  • References: FMA:51800, Wikipedia:Episcleral_layer
  • Contributor: Paola Roncaglia (https://orcid.org/0000-0002-2825-0621)

Changes Made

  • Added new term to src/ontology/uberon-edit.obo following existing patterns
  • Fixed duplicate ID issue by changing from UBERON:7770009 to UBERON:7770011 (UBERON:7770009 was already taken by kidney interpolar region)
  • Included proper metadata: contributor ORCID, creation date, issue tracker reference
  • Used next available ID in the 777xxxx range (UBERON:7770011)
  • Verified term relationships and references are valid

Validation

The new term has been validated using the existing obo-grep.pl tool and confirmed to:

  • Be properly formatted according to OBO standards
  • Have valid parent and part_of relationships
  • Include all required metadata fields
  • Be searchable within the ontology
  • Have a unique ID without conflicts

Fixes #1680.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] NTR: episcleral vein Add episcleral vein term (UBERON:7770009) Jul 10, 2025
Copilot AI requested a review from cmungall July 10, 2025 23:59
Copilot finished work on behalf of cmungall July 10, 2025 23:59
@dosumis
Copy link
Contributor

dosumis commented Jul 14, 2025

#gogoeditdiff

@github-actions
Copy link
Contributor

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2025-07-14/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-main.owl/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2025-07-14/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-pr.owl/uberon-base.owl

Ontology imports

Ontology annotations

episcleral vein http://purl.obolibrary.org/obo/UBERON_7770009

Added

@github-actions
Copy link
Contributor

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

episcleral vein http://purl.obolibrary.org/obo/UBERON_7770009

Added

@cmungall cmungall marked this pull request as ready for review July 21, 2025 10:29
@github-actions
Copy link
Contributor

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

@dosumis
Copy link
Contributor

dosumis commented Sep 15, 2025

@copilot - looks good apart from addition of new file under /terms. Please revert this. The only file that should be edited is src/ontology/uberon-edit.obo.

Copilot AI and others added 2 commits September 15, 2025 17:20
- Changed episcleral vein ID from UBERON:7770009 to UBERON:7770011
- Removed terms/UBERON_7770009.obo file as requested
- Fixed duplicate ID conflict with kidney interpolar region term

@dragon-ai-agent

Co-authored-by: dosumis <[email protected]>
Copy link
Author

Copilot AI commented Sep 15, 2025

@copilot - looks good apart from addition of new file under /terms. Please revert this. The only file that should be edited is src/ontology/uberon-edit.obo.

Fixed! I've removed the terms/UBERON_7770009.obo file and also corrected a duplicate ID issue I discovered. The episcleral vein term now uses UBERON:7770011 instead of the conflicting UBERON:7770009 (which was already taken by kidney interpolar region). Only src/ontology/uberon-edit.obo is now modified as requested. Commit: ff2bb82

Copilot AI changed the title Add episcleral vein term (UBERON:7770009) Add episcleral vein term (UBERON:7770011) Sep 15, 2025
Copilot AI requested a review from dosumis September 15, 2025 17:22
Copilot finished work on behalf of dosumis September 15, 2025 17:22
@github-actions
Copy link
Contributor

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NTR: episcleral vein

3 participants