Skip to content

Commit 324b972

Browse files
committed
chore: revert back to 4.13 for release
ps-id: 4F7AEBE5-3C3A-4EB1-A7E1-3AD5EA62B1E1
1 parent 45a22b1 commit 324b972

File tree

11 files changed

+23
-22
lines changed

11 files changed

+23
-22
lines changed

.github/workflows/build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- ubuntu-latest
2020
- windows-latest
2121
ocaml-compiler:
22-
- 4.14.x
22+
- 4.13.x
2323

2424
runs-on: ${{ matrix.os }}
2525

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ install-test-deps:
2121

2222
.PHONY: dev
2323
dev: ## Setup a development environment
24-
opam switch create --no-install . ocaml-base-compiler.4.14.0
24+
opam switch create --no-install . ocaml-base-compiler.4.13.1
2525
opam install -y dune-release merlin ocamlformat utop ocaml-lsp-server
2626
opam install --locked --deps-only --with-doc -y .
2727
$(MAKE) install-test-deps

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ git clone --recursive [email protected]:ocaml/ocaml-lsp.git
122122
git submodule update --init --recursive
123123

124124
# create local switch (or use global one)
125-
opam switch create . ocaml-base-compiler.4.14.0
125+
opam switch create . ocaml-base-compiler.4.13.0
126126

127127
# don't forget to set your environment to use the local switch
128128
eval $(opam env)

dune-project

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ possible and does not make any assumptions about IO.
6363
(csexp (>= 1.5))
6464
(ocamlformat-rpc-lib (>= 0.21.0))
6565
(odoc :with-doc)
66-
(ocaml (and (>= 4.14) (< 4.15)))))
66+
(ocaml (and (>= 4.13) (< 4.14)))))
6767

6868
(package
6969
(name jsonrpc)

jsonrpc-fiber/test/jsonrpc_fiber_tests.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ let%expect_test "test from jsonrpc_test.ml" =
266266
Uncaught error when handling notification:
267267
{ "method": "raise", "jsonrpc": "2.0" }
268268
Error:
269-
[ { exn = "Failure(\"special failure\")"; backtrace = "" } ]
269+
[ { exn = "(Failure \"special failure\")"; backtrace = "" } ]
270270
<opaque>
271271
{ "id": 10, "jsonrpc": "2.0", "result": 1 }
272272
{ "id": "testing", "jsonrpc": "2.0", "result": 2 } |}]

nix/default.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ let
1313
[ "nix" "shell.nix" "default.nix" ];
1414
in pkgs.nix-gitignore.gitignoreSourcePure ignores ../.;
1515
args = {
16-
inherit (pkgs.ocaml-ng.ocamlPackages_4_14) ocaml;
16+
inherit (pkgs.ocaml-ng.ocamlPackages_4_13) ocaml;
1717
selection = ./opam-selection.nix;
1818
src = {
1919
ocamlformat-rpc-lib = ocamlformat;

nix/opam-selection.nix

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ in
2424
{
2525
format-version = 4;
2626
inherit repos;
27-
ocaml-version = "4.14.0";
27+
ocaml-version = "4.13.1";
2828
selection =
2929
{
3030
astring =
@@ -522,7 +522,7 @@ in
522522
ocaml =
523523
{
524524
pname = "ocaml";
525-
version = "4.14.0";
525+
version = "4.13.1";
526526
src = null;
527527
opamInputs =
528528
{
@@ -534,25 +534,25 @@ in
534534
};
535535
opamSrc = repoPath (repos.opam-repository.src)
536536
{
537-
package = "packages/ocaml/ocaml.4.14.0";
538-
hash = "sha256-uEKCTkEWM1EhLO/zOkZtLP45aWRcN8Z/LFffwK8zkdw=";
537+
package = "packages/ocaml/ocaml.4.13.1";
538+
hash = "sha256:12aajj2hc636jr6wbv4vba8pmjdndbcvnw7q35gj4agxmrjspziw";
539539
};
540540
};
541541
ocaml-base-compiler =
542542
{
543543
pname = "ocaml-base-compiler";
544-
version = "4.14.1";
544+
version = "4.13.1";
545545
src = pkgs.fetchurl
546546
{
547-
url = "https://github.com/ocaml/ocaml/archive/4.14.0.tar.gz";
548-
sha256 = "sha256-uEKCTkEWM1EhLO/zOkZtLP45aWRcN8Z/LFffwK8zkdw=";
547+
url = "https://github.com/ocaml/ocaml/archive/4.13.1.tar.gz";
548+
sha256 = "1i7ad8lh5l74wb3yzmhlv529wc75a5sjybzkad7wdl8zrj47jk0r";
549549
};
550550
opamInputs = {
551551
};
552552
opamSrc = repoPath (repos.opam-repository.src)
553553
{
554-
package = "packages/ocaml-base-compiler/ocaml-base-compiler.4.14.0";
555-
hash = "sha256-uEKCTkEWM1EhLO/zOkZtLP45aWRcN8Z/LFffwK8zkdw=";
554+
package = "packages/ocaml-base-compiler/ocaml-base-compiler.4.13.1";
555+
hash = "sha256:069i5vsndd9lsvdm5wk898nfnc85ww7459nibjg6881ww43w8ck1";
556556
};
557557
};
558558
ocaml-compiler-libs =

ocaml-lsp-server.opam

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ depends: [
3838
"csexp" {>= "1.5"}
3939
"ocamlformat-rpc-lib" {>= "0.21.0"}
4040
"odoc" {with-doc}
41-
"ocaml" {>= "4.14" & < "4.15"}
41+
"ocaml" {>= "4.13" & < "4.14"}
4242
]
4343
dev-repo: "git+https://github.com/ocaml/ocaml-lsp.git"
4444
build: [

ocaml-lsp-server/test/e2e/__tests__/completionItem-resolve.test.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,11 @@ describe("textDocument/completion", () => {
5353

5454
expect(response).toMatchInlineSnapshot(`
5555
Object {
56-
"documentation": "[map2 f [a1; ...; an] [b1; ...; bn]] is
56+
"documentation": " [map2 f [a1; ...; an] [b1; ...; bn]] is
5757
[[f a1 b1; ...; f an bn]].
5858
@raise Invalid_argument if the two lists are determined
59-
to have different lengths. Not tail-recursive.",
59+
to have different lengths. Not tail-recursive.
60+
",
6061
"label": "map2",
6162
}
6263
`);
@@ -74,7 +75,8 @@ describe("textDocument/completion", () => {
7475

7576
expect(response).toMatchInlineSnapshot(`
7677
Object {
77-
"documentation": "[find_all] is another name for {!filter}.",
78+
"documentation": " [find_all] is another name for {!filter}.
79+
",
7880
"label": "find_all",
7981
}
8082
`);

ocaml-lsp-server/test/e2e/__tests__/textDocument-diagnostics.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,7 @@ describe("textDocument/diagnostics", () => {
180180
sig val x : int end
181181
is not included in
182182
sig val x : unit end
183-
Values do not match: val x : int is not included in val x : unit
184-
The type int is not compatible with the type unit",
183+
Values do not match: val x : int is not included in val x : unit",
185184
"range": Object {
186185
"end": Object {
187186
"character": 3,

0 commit comments

Comments
 (0)