Skip to content

Commit 4f07f26

Browse files
committed
remove barriers
1 parent 9b99bc8 commit 4f07f26

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

src/hotspot/cpu/s390/javaFrameAnchor_s390.hpp

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,12 @@
3535
// 3 - restoring an old state (javaCalls).
3636

3737
inline void clear(void) {
38+
// No hardware barriers are necessary. All members are volatile and the profiler
39+
// is run from a signal handler and only observers the thread its running on.
40+
3841
// Clearing _last_Java_sp must be first.
39-
OrderAccess::release();
42+
4043
_last_Java_sp = nullptr;
41-
// Fence?
42-
OrderAccess::fence();
4344

4445
_last_Java_pc = nullptr;
4546
}
@@ -52,21 +53,16 @@
5253
}
5354

5455
void copy(JavaFrameAnchor* src) {
55-
// In order to make sure the transition state is valid for "this"
56+
// No hardware barriers are necessary. All members are volatile and the profiler
57+
// is run from a signal handler and only observers the thread its running on.
58+
5659
// we must clear _last_Java_sp before copying the rest of the new data.
57-
// Hack Alert: Temporary bugfix for 4717480/4721647
58-
// To act like previous version (pd_cache_state) don't null _last_Java_sp
59-
// unless the value is changing.
60-
//
6160
if (_last_Java_sp != src->_last_Java_sp) {
62-
OrderAccess::release();
6361
_last_Java_sp = nullptr;
64-
OrderAccess::fence();
6562
}
6663
_last_Java_pc = src->_last_Java_pc;
6764
// Must be last so profiler will always see valid frame if has_last_frame() is true.
6865

69-
OrderAccess::release();
7066
_last_Java_sp = src->_last_Java_sp;
7167
}
7268

0 commit comments

Comments
 (0)