feat: performance improvements

Signed-off-by: Simon Schrottner <[email protected]>

Author: aepfli

src/main/java/dev/openfeature/sdk/HookContextWithoutData.java

@@ -3,12 +3,9 @@
 import lombok.AccessLevel;
 import lombok.Builder;
 import lombok.Data;
-import lombok.Getter;
 import lombok.NonNull;
 import lombok.Setter;
-import lombok.Value;
 import lombok.With;
-import lombok.experimental.NonFinal;
 
 /**
  * A data class to hold immutable context that {@link Hook} instances use.

src/main/java/dev/openfeature/sdk/HookSupport.java

@@ -75,9 +75,7 @@ private <T> void executeHooks(
             for (Pair<Hook, HookData> hookDataPair : hookDataPairs) {
                 Hook hook = hookDataPair.getLeft();
                 HookData hookData = hookDataPair.getRight();
-                if (hook.supportsFlagValueType(flagValueType)) {
-                    executeChecked(hook, hookData, hookContext, hookCode, hookMethod);
-                }
+                executeChecked(hook, hookData, hookContext, hookCode, hookMethod);
             }
         }
     }
@@ -111,10 +109,8 @@ private <T> void executeHooksUnchecked(
             for (Pair<Hook, HookData> hookDataPair : hookDataPairs) {
                 Hook hook = hookDataPair.getLeft();
                 HookData hookData = hookDataPair.getRight();
-                if (hook.supportsFlagValueType(flagValueType)) {
-                    var hookCtxWithData = HookContextWithData.of(hookContext, hookData);
-                    hookCode.accept(hook, hookCtxWithData);
-                }
+                var hookCtxWithData = HookContextWithData.of(hookContext, hookData);
+                hookCode.accept(hook, hookCtxWithData);
             }
         }
     }
@@ -133,14 +129,12 @@ private EvaluationContext callBeforeHooks(
             Hook hook = hookDataPair.getLeft();
             HookData hookData = hookDataPair.getRight();
 
-            if (hook.supportsFlagValueType(flagValueType)) {
-                // Create a new context with this hook's data
-                HookContext contextWithHookData = HookContextWithData.of(hookCtx, hookData);
-                Optional<EvaluationContext> optional = Optional.ofNullable(hook.before(contextWithHookData, hints))
-                        .orElse(Optional.empty());
-                if (optional.isPresent()) {
-                    context = context.merge(optional.get());
-                }
+            // Create a new context with this hook's data
+            HookContext contextWithHookData = HookContextWithData.of(hookCtx, hookData);
+            Optional<EvaluationContext> optional =
+                    Optional.ofNullable(hook.before(contextWithHookData, hints)).orElse(Optional.empty());
+            if (optional.isPresent()) {
+                context = context.merge(optional.get());
             }
         }
         return context;

src/test/java/dev/openfeature/sdk/benchmark/AllocationBenchmark.java

@@ -54,6 +54,30 @@ public Optional<EvaluationContext> before(HookContext<Object> ctx, Map<String, O
                 return Optional.ofNullable(new ImmutableContext());
             }
         });
+        client.addHooks(new Hook<String>() {
+            @Override
+            public Optional<EvaluationContext> before(HookContext<String> ctx, Map<String, Object> hints) {
+                return Optional.ofNullable(new ImmutableContext());
+            }
+        });
+        client.addHooks(new Hook<Boolean>() {
+            @Override
+            public Optional<EvaluationContext> before(HookContext<Boolean> ctx, Map<String, Object> hints) {
+                return Optional.ofNullable(new ImmutableContext());
+            }
+        });
+        client.addHooks(new Hook<Integer>() {
+            @Override
+            public Optional<EvaluationContext> before(HookContext<Integer> ctx, Map<String, Object> hints) {
+                return Optional.ofNullable(new ImmutableContext());
+            }
+        });
+        client.addHooks(new Hook<Double>() {
+            @Override
+            public Optional<EvaluationContext> before(HookContext<Double> ctx, Map<String, Object> hints) {
+                return Optional.ofNullable(new ImmutableContext());
+            }
+        });
 
         Map<String, Value> invocationAttrs = new HashMap<>();
         invocationAttrs.put("invoke", new Value(3));