fixup: pmd fix and remove equals

Signed-off-by: Todd Baert <[email protected]>

Author: toddbaert

src/main/java/dev/openfeature/sdk/EventProvider.java

@@ -102,15 +102,4 @@ protected void emitProviderStale(ProviderEventDetails details) {
     protected void emitProviderError(ProviderEventDetails details) {
         emit(ProviderEvent.PROVIDER_ERROR, details);
     }
-
-    @Override
-    public boolean equals(Object obj) {
-        if (obj == null) {
-            return false;
-        }
-        if (obj instanceof FeatureProviderStateManager) {
-            return this == ((FeatureProviderStateManager) obj).getProvider();
-        }
-        return this == obj;
-    }
 }

src/main/java/dev/openfeature/sdk/ProviderRepository.java

@@ -184,7 +184,9 @@ private void prepareAndInitializeProvider(String domain,
 
     private FeatureProviderStateManager getExistingStateManagerForProvider(FeatureProvider provider) {
         for (FeatureProviderStateManager stateManager : stateManagers.values()) {
-            if (stateManager.hasSameProvider(provider)) return stateManager;
+            if (stateManager.hasSameProvider(provider)) {
+                return stateManager;
+            }
         }
         FeatureProviderStateManager defaultFeatureProviderStateManager = defaultStateManger.get();
         if (defaultFeatureProviderStateManager.hasSameProvider(provider)) {
@@ -231,19 +233,19 @@ private void shutDownOld(FeatureProviderStateManager oldProvider, Consumer<Featu
     /**
      * Helper to check if provider is already known (registered).
      *
-     * @param provider provider to check for registration
+     * @param manager manager to check for registration
      * @return boolean true if already registered, false otherwise
      */
-    private boolean isStateManagerRegistered(FeatureProviderStateManager provider) {
-        return provider != null
-                && (this.stateManagers.containsValue(provider) || this.defaultStateManger.get().equals(provider));
+    private boolean isStateManagerRegistered(FeatureProviderStateManager manager) {
+        return manager != null
+                && (this.stateManagers.containsValue(manager) || this.defaultStateManger.get().equals(manager));
     }
 
-    private void shutdownProvider(FeatureProviderStateManager provider) {
-        if (provider == null) {
+    private void shutdownProvider(FeatureProviderStateManager manager) {
+        if (manager == null) {
             return;
         }
-        shutdownProvider(provider.getProvider());
+        shutdownProvider(manager.getProvider());
     }
 
     private void shutdownProvider(FeatureProvider provider) {

src/test/java/dev/openfeature/sdk/EventsTest.java

@@ -606,7 +606,6 @@ void removedEventsShouldNotRun() {
             final Consumer<EventDetails> handler2 = mockHandler();
 
             TestEventsProvider provider = new TestEventsProvider(INIT_DELAY);
-            provider.initialize(null);
             OpenFeatureAPI.getInstance().setProviderAndWait(name, provider);
             Client client = OpenFeatureAPI.getInstance().getClient(name);
 
@@ -619,7 +618,7 @@ void removedEventsShouldNotRun() {
 
             // emit event
             provider.mockEvent(ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, ProviderEventDetails.builder().build());
-
+            
             // both global and client handlers should not run.
             verify(handler1, after(TIMEOUT).never()).accept(any());
             verify(handler2, never()).accept(any());

src/test/java/dev/openfeature/sdk/HookSpecTest.java

@@ -149,7 +149,7 @@ void optional_properties() {
     @Test
     void before_runs_ahead_of_evaluation() {
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
-        api.setProvider(new AlwaysBrokenProvider());
+        api.setProviderAndWait(new AlwaysBrokenProvider());
         Client client = api.getClient();
         Hook<Boolean> evalHook = mockBooleanHook();