Skip to content

Commit 434de4e

Browse files
committed
improve accessibility
1 parent a4b8230 commit 434de4e

File tree

3 files changed

+37
-28
lines changed

3 files changed

+37
-28
lines changed

components/ConnectorsInfo/ConnectorsInfo.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import classNames from "classnames";
2-
import { uniqBy } from "lodash";
2+
import {uniqBy} from "lodash";
33
import dynamic from "next/dynamic";
44
import Link from "next/link";
5-
import { useState } from "react";
6-
import { useDocVersionContext } from "../../context/DocVersionContext";
5+
import {useState} from "react";
6+
import {useDocVersionContext} from "../../context/DocVersionContext";
77
import {
88
getConnectorURL,
99
getSortedServiceList,
1010
} from "../../utils/ConnectorsUtils";
1111
import Loader from "../common/Loader/Loader";
12-
import { CONNECTORS } from "./ConnectorsInfo.constants";
13-
import { ConnectorCategory } from "./ConnectorsInfo.interface";
12+
import {CONNECTORS} from "./ConnectorsInfo.constants";
13+
import {ConnectorCategory} from "./ConnectorsInfo.interface";
1414
import styles from "./ConnectorsInfo.module.css";
1515

1616
const ConnectorImage = dynamic(() => import("./ConnectorImage"), {
@@ -26,7 +26,7 @@ CONNECTORS.unshift({
2626
});
2727

2828
export default function ConnectorsInfo() {
29-
const { docVersion } = useDocVersionContext();
29+
const {docVersion} = useDocVersionContext();
3030
const [selectedTab, setSelectedTab] = useState<ConnectorCategory>(
3131
CONNECTORS[0]
3232
);
@@ -60,7 +60,7 @@ export default function ConnectorsInfo() {
6060
<ConnectorImage
6161
className={styles.ConnectorImg}
6262
src={connector.icon}
63-
alt={connector.name}
63+
alt={`${connector.name}-icon`}
6464
/>
6565
<p>{connector.name}</p>
6666
</Link>

components/Footer/Footer.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@ export default function Footer() {
2727
</nav>
2828
<section className={styles.SocialNetworks}>
2929
{footerIconItemsData.map((item) => (
30-
<Link href={item.href} key={item.href} target="_blank">
30+
<Link
31+
href={item.href}
32+
key={item.href}
33+
target="_blank"
34+
aria-label={item.href}
35+
>
3136
{item.icon}
3237
</Link>
3338
))}

components/TopNav/TopNav.tsx

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
import algoliasearch from "algoliasearch/lite";
22
import classNames from "classnames";
3-
import { isEmpty, isString } from "lodash";
3+
import {isEmpty, isString} from "lodash";
44
import Link from "next/link";
5-
import { useRouter } from "next/router";
6-
import { useCallback, useEffect, useState } from "react";
7-
import { MdMenu, MdMenuOpen } from "react-icons/md";
8-
import { InstantSearch } from "react-instantsearch";
5+
import {useRouter} from "next/router";
6+
import {useCallback, useEffect, useState} from "react";
7+
import {MdMenu, MdMenuOpen} from "react-icons/md";
8+
import {InstantSearch} from "react-instantsearch";
99
import {
1010
DEFAULT_VERSION,
1111
REGEX_VERSION_MATCH,
1212
REGEX_VERSION_MATCH_WITH_SLASH_AT_START,
1313
} from "../../constants/version.constants";
14-
import { useDocVersionContext } from "../../context/DocVersionContext";
15-
import { useNavBarCollapsedContext } from "../../context/NavBarCollapseContext";
16-
import { SearchContextProvider } from "../../context/SearchContext";
17-
import { ReactComponent as ApiIcon } from "../../images/icons/api.svg";
18-
import { ReactComponent as CloudIcon } from "../../images/icons/cloud.svg";
19-
import { ReactComponent as GithubIcon } from "../../images/icons/github.svg";
20-
import { ReactComponent as OMDIcon } from "../../images/icons/omd.svg";
21-
import { ReactComponent as SlackIcon } from "../../images/icons/slack.svg";
22-
import { getUrlWithVersion } from "../../utils/CommonUtils";
14+
import {useDocVersionContext} from "../../context/DocVersionContext";
15+
import {useNavBarCollapsedContext} from "../../context/NavBarCollapseContext";
16+
import {SearchContextProvider} from "../../context/SearchContext";
17+
import {ReactComponent as ApiIcon} from "../../images/icons/api.svg";
18+
import {ReactComponent as CloudIcon} from "../../images/icons/cloud.svg";
19+
import {ReactComponent as GithubIcon} from "../../images/icons/github.svg";
20+
import {ReactComponent as OMDIcon} from "../../images/icons/omd.svg";
21+
import {ReactComponent as SlackIcon} from "../../images/icons/slack.svg";
22+
import {getUrlWithVersion} from "../../utils/CommonUtils";
2323
import Search from "../Search/Search";
24-
import SelectDropdown, { SelectOption } from "../SelectDropdown/SelectDropdown";
24+
import SelectDropdown, {SelectOption} from "../SelectDropdown/SelectDropdown";
2525
import styles from "./TopNav.module.css";
2626

2727
const searchClient = algoliasearch(
@@ -33,12 +33,12 @@ interface TopNavProps {
3333
versionsList: Array<SelectOption<string>>;
3434
}
3535

36-
export default function TopNav({ versionsList }: Readonly<TopNavProps>) {
36+
export default function TopNav({versionsList}: Readonly<TopNavProps>) {
3737
const router = useRouter();
3838
const [displayNavBarCollapseButton, setDisplayNavBarCollapseButton] =
3939
useState(false);
40-
const { docVersion, onChangeDocVersion } = useDocVersionContext();
41-
const { navBarCollapsed, onChangeNavBarCollapsed } =
40+
const {docVersion, onChangeDocVersion} = useDocVersionContext();
41+
const {navBarCollapsed, onChangeNavBarCollapsed} =
4242
useNavBarCollapsedContext();
4343

4444
const handleVersionChange = (value: string) => {
@@ -87,7 +87,10 @@ export default function TopNav({ versionsList }: Readonly<TopNavProps>) {
8787
>
8888
<div className={styles.CollapsedDivContainer}>
8989
<div className={styles.LogoContainer}>
90-
<Link href={docVersion ? getUrlWithVersion("/", docVersion) : "/"}>
90+
<Link
91+
href={docVersion ? getUrlWithVersion("/", docVersion) : "/"}
92+
aria-label="omd-icon"
93+
>
9194
<OMDIcon />
9295
</Link>
9396
{!isEmpty(versionsList) && (
@@ -136,8 +139,9 @@ export default function TopNav({ versionsList }: Readonly<TopNavProps>) {
136139
className="btn fw-500 btn-primary rounded-pill"
137140
href="https://cloud.getcollate.io"
138141
target="_blank"
142+
aria-label="cloud-icon"
139143
>
140-
<button className={styles.CloudBtn}>
144+
<button className={styles.CloudBtn} aria-label="cloud-icon">
141145
<CloudIcon />
142146
</button>
143147
</a>

0 commit comments

Comments
 (0)