Merge pull request #150 from open-runtimes/fix-realtime-race-condition

Meldiron · web-flow · commit 91eb47d1cc87 · 2025-03-21T14:21:51.000+01:00
Fix: logging race condition
diff --git a/app/http.php b/app/http.php
@@ -440,8 +440,11 @@ function cleanUp(Orchestration $orchestration, Table $activeRuntimes, array $net
                 throw new Exception('Log file was not created in time.', 400);
             }
 
-            if (\file_exists($tmpLogging . '/logs.txt') && file_exists($tmpLogging . '/timings.txt')) {
-                break;
+            if (\file_exists($tmpLogging . '/logs.txt') && \file_exists($tmpLogging . '/timings.txt')) {
+                $timings = \file_get_contents($tmpLogging . '/timings.txt') ?: '';
+                if (\strlen($timings) > 0) {
+                    break;
+                }
             }
 
             // Ensure runtime is still present

Original file line number	Diff line number	Diff line change
`@@ -440,8 +440,11 @@ function cleanUp(Orchestration $orchestration, Table $activeRuntimes, array $net`
`440`	`440`	`throw new Exception('Log file was not created in time.', 400);`
`441`	`441`	`}`
`442`	`442`
`443`		`- if (\file_exists($tmpLogging . '/logs.txt') && file_exists($tmpLogging . '/timings.txt')) {`
`444`		`- break;`
	`443`	`+ if (\file_exists($tmpLogging . '/logs.txt') && \file_exists($tmpLogging . '/timings.txt')) {`
	`444`	`+ $timings = \file_get_contents($tmpLogging . '/timings.txt') ?: '';`
	`445`	`+ if (\strlen($timings) > 0) {`
	`446`	`+ break;`
	`447`	`+ }`
`445`	`448`	`}`
`446`	`449`
`447`	`450`	`// Ensure runtime is still present`