Skip to content

Conversation

@jgreitemann
Copy link
Contributor

Changes

Fixes the code sample for registering a CustomLogHandler implementation on the Getting Started page:

  • Remove erroneous backslash escapes in pointers.
  • Pass CustomLogHandler instance as shared_ptr.

Creating this as a draft PR for now, as I need to sort out the CLA.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jgreitemann / name: Jonas Greitemann (c3eba99)
  • ✅ login: marcalff / name: Marc Alff (d9c5ff7)

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (d37c579) to head (d9c5ff7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
- Coverage   90.01%   90.00%   -0.01%     
==========================================
  Files         225      225              
  Lines        7105     7105              
==========================================
- Hits         6395     6394       -1     
- Misses        710      711       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff
Copy link
Member

/easycla

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Nov 12, 2025
- Remove erroneous backslash escapes in pointers.
- Pass `CustomLogHandler` instance as `shared_ptr`.
@jgreitemann jgreitemann force-pushed the docs-fix-customloghandler-code-sample branch from b776ec5 to c3eba99 Compare November 13, 2025 22:36
@jgreitemann jgreitemann marked this pull request as ready for review November 13, 2025 22:50
@jgreitemann jgreitemann requested a review from a team as a code owner November 13, 2025 22:50
@jgreitemann
Copy link
Contributor Author

Finally sorted out the CLA. Sorry for the delay.

@marcalff marcalff added documentation Improvements or additions to documentation and removed pr:waiting-on-cla Waiting on CLA labels Nov 14, 2025
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@marcalff marcalff merged commit ace49b7 into open-telemetry:main Nov 14, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants