Skip to content

Fix metric.v8js.memory.heap.space.physical_size and metric.v8js.memory.heap.space.available_size metric names #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2025
Merged

Fix metric.v8js.memory.heap.space.physical_size and metric.v8js.memory.heap.space.available_size metric names #2856

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e93cedc
update v8js
maryliag Oct 2, 2025
8e69913
update markdown
maryliag Oct 2, 2025
1e40322
create deprecated metric info
maryliag Oct 2, 2025
846e235
fix lint
maryliag Oct 2, 2025
f7c3a12
fix lint
maryliag Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/runtime/v8js-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ This document describes semantic conventions for V8 JS Engine Runtime metrics in
- [Metric: `v8js.gc.duration`](#metric-v8jsgcduration)
- [Metric: `v8js.memory.heap.limit`](#metric-v8jsmemoryheaplimit)
- [Metric: `v8js.memory.heap.used`](#metric-v8jsmemoryheapused)
- [Metric: `v8js.heap.space.available_size`](#metric-v8jsheapspaceavailable_size)
- [Metric: `v8js.heap.space.physical_size`](#metric-v8jsheapspacephysical_size)
- [Metric: `v8js.memory.heap.space.available_size`](#metric-v8jsmemoryheapspaceavailable_size)
- [Metric: `v8js.memory.heap.space.physical_size`](#metric-v8jsmemoryheapspacephysical_size)

<!-- tocstop -->

Expand Down Expand Up @@ -181,11 +181,11 @@ This metric is [recommended][MetricRecommended].
<!-- END AUTOGENERATED TEXT -->
<!-- endsemconv -->

## Metric: `v8js.heap.space.physical_size`
## Metric: `v8js.memory.heap.space.physical_size`

This metric is [recommended][MetricRecommended].

<!-- semconv metric.v8js.heap.space.physical_size -->
<!-- semconv metric.v8js.memory.heap.space.physical_size -->
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
<!-- see templates/registry/markdown/snippet.md.j2 -->
<!-- prettier-ignore-start -->
Expand Down
8 changes: 4 additions & 4 deletions model/v8js/metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ groups:
The value can be retrieved from value `space_used_size` of
[`v8.getHeapSpaceStatistics()`](https://nodejs.org/api/v8.html#v8getheapspacestatistics)

- id: metric.v8js.heap.space.available_size
- id: metric.v8js.memory.heap.space.available_size
type: metric
metric_name: v8js.heap.space.available_size
metric_name: v8js.memory.heap.space.available_size
annotations:
code_generation:
metric_value_type: int
Expand All @@ -65,9 +65,9 @@ groups:
note: >
Value can be retrieved from value `space_available_size` of [`v8.getHeapSpaceStatistics()`](https://nodejs.org/api/v8.html#v8getheapspacestatistics)

- id: metric.v8js.heap.space.physical_size
- id: metric.v8js.memory.heap.space.physical_size
type: metric
metric_name: v8js.heap.space.physical_size
metric_name: v8js.memory.heap.space.physical_size
annotations:
code_generation:
metric_value_type: int
Expand Down
Loading