Skip to content

Commit 5fa63e5

Browse files
markdownlint: fixes
Signed-off-by: Patrick Williams <[email protected]> Change-Id: I5d07d550b9c483de6c4d5f64570ea8336564297a
1 parent 7fb9bb4 commit 5fa63e5

File tree

9 files changed

+56
-59
lines changed

9 files changed

+56
-59
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Contributing to WebUI-Vue
1+
# Contributing to WebUI-Vue
22

33
:+1::tada: First off, thanks for taking the time to contribute! :+1::tada:
44

@@ -7,10 +7,8 @@ The following is a set of guidelines for contributing to the OpenBMC Web UI.
77
## Table of contents
88

99
- [Project Setup](#project-setup)
10-
- [Code of Conduct](#code-of-conduct)
1110
- [Asking Questions](#asking-questions)
1211
- [Submitting Bugs](#submitting-bugs)
13-
- [Request a New Feature](#request-a-new-feature)
1412
- [User Research](#user-research)
1513
- [Design Reviews](#design-reviews)
1614
- [Help Wanted](#help-wanted)
@@ -30,15 +28,15 @@ Since we use Gerrit to manage all the code contributions, it is not necessary to
3028
create a fork from GitHub. Read more about submitting a code review in the
3129
[Code Reviews section](#code-reviews) below.
3230

33-
1. Visit https://gerrit.openbmc-project.xyz/admin/repos/openbmc/webui-vue
31+
1. Visit <https://gerrit.openbmc-project.xyz/admin/repos/openbmc/webui-vue>
3432
2. Clone the repo using the `Clone with commit-msg hook` link
3533
- Windows users may need to separate the two commands depending on if they
3634
have installed a Bash emulator like `Git for Windows` or `CMDER` or
3735
installed the `Windows Subsystem for Linux`.
3836

3937
### Install Dependencies
4038

41-
```
39+
```shell
4240
npm install
4341
```
4442

@@ -47,29 +45,29 @@ npm install
4745
1. Create the following file in the root directory
4846
- .env.development.local
4947
1. Add the following environment variable
50-
- BASE_URL="https://<BMC IP address or FQDN>"`
48+
- `BASE_URL="https://<BMC IP address or FQDN>"`
5149

5250
### Compile and hot-reload for development
5351

54-
```
52+
```shell
5553
npm run serve
5654
```
5755

5856
### Run Documentation Locally (Vuepress static site generation)
5957

60-
```
58+
```shell
6159
npm run docs:serve
6260
```
6361

6462
### Run unit tests
6563

66-
```
64+
```shell
6765
npm run test:unit
6866
```
6967

7068
### Lint and fix files
7169

72-
```
70+
```shell
7371
npm run lint
7472
```
7573

@@ -82,8 +80,8 @@ The OpenBMC communicates using a mail list and the Discord channel. Although you
8280
could create a GitHub issue to ask a question, a better option would be to ask
8381
your question using the email list or Discord channel.
8482

85-
- Mail: [email protected] https://lists.ozlabs.org/listinfo/openbmc
86-
- Discord: https://discord.gg/69Km47zH98
83+
- Mail: <[email protected]> <https://lists.ozlabs.org/listinfo/openbmc>
84+
- Discord: <https://discord.gg/69Km47zH98>
8785

8886
### Submitting Bugs
8987

docs/customization/build.md

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,21 @@ modifications to the Web UI.
1919

2020
Example `.env.ibm`:
2121

22-
```
22+
```shell
2323
NODE_ENV=production
2424
VUE_APP_ENV_NAME=ibm
2525
```
2626

2727
## Store
2828

29-
:::tip [Vuex store modules](https://vuex.vuejs.org/guide/modules.html) contain
30-
the application's API calls. :::
29+
**tip** [Vuex store modules](https://vuex.vuejs.org/guide/modules.html) contain
30+
the application's API calls.
3131

3232
1. If making customizations to the default store, add `CUSTOM_STORE=true` key
3333
value pair to the new .env file.
34-
2. Create a `<ENV_NAME>.js` file in `src/env/store` :::danger The filename needs
35-
to match the `VUE_APP_ENV_NAME` value defined in the .env file. The store
36-
import in `src/main.js` will resolve to this new file. :::
34+
2. Create a `<ENV_NAME>.js` file in `src/env/store` **danger** The filename
35+
needs to match the `VUE_APP_ENV_NAME` value defined in the .env file. The
36+
store import in `src/main.js` will resolve to this new file.
3737
3. Import the base store
3838
4. Import environment specific store modules
3939
5. Use the [Vuex](https://vuex.vuejs.org/api/#registermodule) `registerModule`
@@ -42,7 +42,7 @@ the application's API calls. :::
4242

4343
Example `src/env/store/ibm.js`:
4444

45-
```
45+
```js
4646
import store from '@/store; //@ aliases to src directory
4747
import HmcStore from './Hmc/HmcStore';
4848
@@ -53,17 +53,17 @@ export default store;
5353
5454
## Router
5555
56-
:::tip [Vue Router](https://router.vuejs.org/guide/) determines which pages are
57-
accessible in the UI. :::
56+
**tip** [Vue Router](https://router.vuejs.org/guide/) determines which pages are
57+
accessible in the UI.
5858
5959
1. If making customizations to the default router, add `CUSTOM_ROUTER=true` key
6060
value pair to the new .env file.
61-
2. Create a `<ENV_NAME>.js` file in `src/env/router` :::danger The filename
61+
2. Create a `<ENV_NAME>.js` file in `src/env/router` **danger** The filename
6262
needs to match the `VUE_APP_ENV_NAME` value defined in the .env file. The
63-
routes import in `src/router/index.js` will resolve to this new file. :::
64-
3. Define new [routes](https://router.vuejs.org/api/#routes). :::tip Use static
63+
routes import in `src/router/index.js` will resolve to this new file.
64+
3. Define new [routes](https://router.vuejs.org/api/#routes). **tip** Use static
6565
imports (over lazy-loading routes) to avoid creating separate JS chunks.
66-
Static imports also helps to keep the total build size down. :::
66+
Static imports also helps to keep the total build size down.
6767
4. Add default export
6868
6969
## App navigation
@@ -76,11 +76,11 @@ in src/components/AppNavigation/AppNavigation.vue.
7676
7777
1. If making customizations to the app navigation, add `CUSTOM_APP_NAV=true` key
7878
value pair to the new .env file.
79-
2. Create a `<ENV_NAME>.js` file in `src/env/components/AppNavigation` :::danger
80-
The filename needs to match the `VUE_APP_ENV_NAME` value defined in the .env
81-
file. The AppNavigationMixin import in
79+
2. Create a `<ENV_NAME>.js` file in `src/env/components/AppNavigation`
80+
**danger** The filename needs to match the `VUE_APP_ENV_NAME` value defined
81+
in the .env file. The AppNavigationMixin import in
8282
`src/components/AppNavigation/AppNavigation.vue` will resolve to this new
83-
file. :::
83+
file.
8484
3. Your custom mixin should follow a very similar structure to the default
8585
AppNavigationMixin.js file. It should include a data property named
8686
`navigationItems` that should be an array of of navigation objects. Each
@@ -90,16 +90,15 @@ in src/components/AppNavigation/AppNavigation.vue.
9090
9191
## Theming
9292
93-
:::tip
93+
**tip**
9494
[Bootstrap theming](https://getbootstrap.com/docs/4.5/getting-started/theming/)
95-
allows for easy visual customizations. :::
95+
allows for easy visual customizations.
9696
9797
1. If making customizations to the default styles, add `CUSTOM_STYLES=true` key
9898
value pair to the new .env file.
99-
2. Create a `_<ENV_NAME>.scss` partial in `src/env/assets/styles` :::danger The
100-
filename needs to match the `VUE_APP_ENV_NAME` value defined in the .env
99+
2. Create a `_<ENV_NAME>.scss` partial in `src/env/assets/styles`. **danger**
100+
The filename needs to match the `VUE_APP_ENV_NAME` value defined in the .env
101101
file. The webpack sass loader will attempt to import a file with this name.
102-
:::
103102
3. Add style customizations. Refer to
104103
[bootstrap documentation](https://getbootstrap.com/docs/4.5/getting-started/theming/)
105104
for details about
@@ -111,7 +110,7 @@ Example for adding custom colors
111110
112111
`src/env/assets/styles/_ibm.scss`
113112
114-
```
113+
```css
115114
// Custom theme colors
116115
117116
$primary: rebeccapurple;
@@ -123,7 +122,8 @@ $success: lime;
123122
1. Add the same `VUE_APP_ENV_NAME` key value pair to your
124123
`env.development.local` file.
125124
2. Use serve script
126-
```
125+
126+
```shell
127127
npm run serve
128128
```
129129
@@ -133,14 +133,14 @@ Run npm build script with vue-cli `--mode`
133133
[option flag](https://cli.vuejs.org/guide/mode-and-env.html#modes). This
134134
requires [corresponding .env file to exist](#setup).
135135
136-
```
136+
```shell
137137
npm run build -- --mode ibm
138138
```
139139
140-
**OR**
140+
OR
141141
142142
pass env variable directly to script
143143
144-
```
144+
```shell
145145
VUE_APP_ENV_NAME=ibm npm run build
146146
```

docs/guide/components/buttons/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ like a link, set the variant value to `link`.
88

99
[Learn more about Bootstrap-vue buttons](https://bootstrap-vue.js.org/docs/components/button)
1010

11-
### Icon only buttons
11+
## Icon only buttons
1212

1313
Add `btn-icon-only` class to the button and add `title` attribute to get helper
1414
text on hover over the button.
1515

16-
### Enabled buttons
16+
## Enabled buttons
1717

1818
![Button examples](./button.png)
1919

@@ -36,7 +36,7 @@ text on hover over the button.
3636
</b-button>
3737
```
3838

39-
### Disabled buttons
39+
## Disabled buttons
4040

4141
![Disabled button examples](./button-disabled.png)
4242

docs/guide/components/file-upload/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ To use this component:
1111

1212
[Learn more about the Bootstrap-vue Form File component](https://bootstrap-vue.org/docs/components/form-file)
1313

14-
### Optional properties
14+
## Optional properties
1515

1616
- `id`- Used to set the `id` attribute on the rendered content, and used as the
1717
base to generate any additional element IDs as needed

docs/guide/components/table/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ export default {
379379

380380
To add a table dropdown filter:
381381

382-
1. Import the `<table-filter> `component and TableFilterMixin.
382+
1. Import the `<table-filter>` component and `TableFilterMixin`.
383383
1. Add a filters prop to the `<table-filters>` component. This prop should be an
384384
array of filter groups–each required to have a key, label, and values prop.
385385

@@ -458,7 +458,7 @@ once.
458458

459459
To add table batch actions:
460460

461-
1. Import the `<table-toolbar> `component and BVTableSelectableMixin
461+
1. Import the `<table-toolbar>` component and `BVTableSelectableMixin`
462462
1. Add the `selectable`, `no-select-on-click` props and a unique `ref` to the
463463
table. The table will emit a `@row-selected` event. Use the `onRowSelected`
464464
mixin method as a callback and provide the `$event` as the first argument and

docs/guide/components/toasts/index.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ message will auto-hide after 10 seconds. The user must manually dismiss the
1111
provides a simple API that generates a toast message that meets the transition
1212
guidelines.
1313

14-
<img src="./toast.png" alt="Toast message examples" style="max-width:350px">
14+
![Toast message examples](toast.png)
1515

1616
```js{5}
1717
// Sample method from Reboot BMC page
@@ -51,8 +51,7 @@ object with a `title` property to change the default toast title. Include a
5151
application. Include a `timestamp` property, set to true, to include a timestamp
5252
in the toast.
5353

54-
<img src="./toast-options.png" alt="Toast message options example"
55-
style="max-width:350px">
54+
![Toast message options example](toast-options.png)
5655

5756
```js
5857

docs/guide/guidelines/colors.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,23 @@ colors to override default styles set by the Bootstrap library.
1313

1414
## Grays
1515

16-
<colors-grays/>
16+
`<colors-grays/>`
1717

1818
## Blues
1919

20-
<colors-blues/>
20+
`<colors-blues/>`
2121

2222
## Greens
2323

24-
<colors-greens/>
24+
`<colors-greens/>`
2525

2626
## Reds
2727

28-
<colors-reds/>
28+
`<colors-reds/>`
2929

3030
## Yellows
3131

32-
<colors-yellows/>
32+
`<colors-yellows/>`
3333

3434
## All Colors
3535

@@ -38,7 +38,7 @@ colors to override default styles set by the Bootstrap library.
3838
`theme-colors` map colors.
3939

4040
[Learn more about the Bootstrap color maps](https://getbootstrap.com/docs/4.0/getting-started/theming/#all-colors).
41-
<colors-all/>
41+
`<colors-all/>`
4242

4343
## Theme Colors
4444

@@ -48,4 +48,4 @@ component.
4848

4949
[Learn more about the Bootstrap theme-colors maps](https://getbootstrap.com/docs/4.0/getting-started/theming/#theme-colors).
5050

51-
<colors-theme/>
51+
`<colors-theme/>`

docs/guide/guidelines/motion.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ for expressive motion.
2323

2424
### Easing tokens
2525

26-
```
26+
```css
2727
$standard-easing--productive: cubic-bezier(0.2, 0, 0.38, 0.9);
2828
$standard-easing--expressive: cubic-bezier(0.4, 0.14, 0.3, 1);
2929
$entrance-easing--productive: cubic-bezier(0, 0, 0.38, 0.9);
@@ -42,7 +42,7 @@ longer the animation takes.
4242

4343
### Duration tokens
4444

45-
```
45+
```css
4646
$duration--fast-01: 70ms; //Micro-interactions such as button and toggle
4747
$duration--fast-02: 110ms; //Micro-interactions such as fade
4848
$duration--moderate-01: 150ms; //Micro-interactions, small expansion, short distance movements

docs/guide/unit-testing/readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ the internals of the component.
1010
> not too few, but just enough. Thousands of tests for a small application can
1111
> be as damaging to development time as no tests.
1212
>
13-
> -- <cite>Ed Yerburgh, Testing Vue Applications (New York: Manning
14-
> Publications, 2019)</cite>
13+
> -- Ed Yerburgh, Testing Vue Applications (New York: Manning
14+
> Publications, 2019)
1515
1616
## Test Libraries
1717

0 commit comments

Comments
 (0)