From dd01d09c0d2922a9d0a082a3728c8844de1a419a Mon Sep 17 00:00:00 2001 From: pandeytejas <139737655+pandeytejas@users.noreply.github.com> Date: Thu, 28 Aug 2025 16:13:00 +0000 Subject: [PATCH 1/4] Add SAI_ATTR_PORT_FW_REVISION to saiport This proposal outlines the addition of a new port attribute designed to provide a standardized method for querying the active firmware revision of a port. Proposal - Add label SAI_ATTR_PORT_FW_REVISION under sai_port_attr_h in saiport.h to store firmware related information. This attribute will store a string denoting the current firmware version running on the port. This can denote either the SerDes firmware version or any other vendor specific firmware version that needs to be exported. Signed-off-by: Tejas Pandey --- inc/saiport.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/inc/saiport.h b/inc/saiport.h index ae7196fbb..b54bad78b 100644 --- a/inc/saiport.h +++ b/inc/saiport.h @@ -2687,6 +2687,26 @@ typedef enum _sai_port_attr_t */ SAI_PORT_ATTR_PAM4_EYE_VALUES, + /** + * @brief Get port firmware revision + * + * Standard attribute to collect port SerDes firmware rev or + * any other vendor specific firmware rev. + * + * @type sai_s8_list_t + * @flags READ_ONLY + */ + + SAI_PORT_ATTR_FW_REVISION, + + /** + * @brief The maximum size of SAI_PORT_ATTR_FW_REVISION in bytes. + * + * @type sai_uint32_t + * @flags READ_ONLY + */ + SAI_PORT_ATTR_FW_REVISION_SIZE, + /** * @brief End of attributes */ From 288a1eae985de3a08dd506857de0385054a65f24 Mon Sep 17 00:00:00 2001 From: pandeytejas <139737655+pandeytejas@users.noreply.github.com> Date: Thu, 28 Aug 2025 16:13:00 +0000 Subject: [PATCH 2/4] Add SAI_ATTR_PORT_FW_REVISION to saiport This proposal outlines the addition of a new port attribute designed to provide a standardized method for querying the active firmware revision of a port. Proposal - Add label SAI_ATTR_PORT_FW_REVISION under sai_port_attr_h in saiport.h to store firmware related information. This attribute will store a string denoting the current firmware version running on the port. This can denote either the SerDes firmware version or any other vendor specific firmware version that needs to be exported. Signed-off-by: Tejas Pandey --- inc/saiport.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/inc/saiport.h b/inc/saiport.h index b54bad78b..f0d995af0 100644 --- a/inc/saiport.h +++ b/inc/saiport.h @@ -2697,15 +2697,7 @@ typedef enum _sai_port_attr_t * @flags READ_ONLY */ - SAI_PORT_ATTR_FW_REVISION, - - /** - * @brief The maximum size of SAI_PORT_ATTR_FW_REVISION in bytes. - * - * @type sai_uint32_t - * @flags READ_ONLY - */ - SAI_PORT_ATTR_FW_REVISION_SIZE, + SAI_PORT_ATTR_SERDES_FW_REVISION, /** * @brief End of attributes From a94d88ea4c535bacff1e4524c162cd3b21865f0e Mon Sep 17 00:00:00 2001 From: pandeytejas <139737655+pandeytejas@users.noreply.github.com> Date: Thu, 28 Aug 2025 16:13:00 +0000 Subject: [PATCH 3/4] Add SAI_ATTR_PORT_FW_REVISION to saiport This proposal outlines the addition of a new port attribute designed to provide a standardized method for querying the active SerDes firmware revision of a port. Proposal - Add label SAI_ATTR_PORT_FW_REVISION under sai_port_attr_h in saiport.h to store firmware related information. This attribute will store a string denoting the current SerDes firmware version running on the port. Signed-off-by: Tejas Pandey --- inc/saiport.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/inc/saiport.h b/inc/saiport.h index f0d995af0..705cfa39e 100644 --- a/inc/saiport.h +++ b/inc/saiport.h @@ -2690,8 +2690,7 @@ typedef enum _sai_port_attr_t /** * @brief Get port firmware revision * - * Standard attribute to collect port SerDes firmware rev or - * any other vendor specific firmware rev. + * Standard attribute to collect port SerDes firmware rev. * * @type sai_s8_list_t * @flags READ_ONLY From 20986ed5c0d92f7fe9795938bb6eeb659adf9cf0 Mon Sep 17 00:00:00 2001 From: pandeytejas <139737655+pandeytejas@users.noreply.github.com> Date: Thu, 28 Aug 2025 16:13:00 +0000 Subject: [PATCH 4/4] Add SAI_ATTR_PORT_FW_REVISION to saiport This proposal outlines the addition of a new port attribute designed to provide a standardized method for querying the active SerDes firmware revision of a port. Proposal - Add label SAI_ATTR_PORT_FW_REVISION under sai_port_attr_h in saiport.h to store firmware related information. This attribute will store a string denoting the current SerDes firmware version running on the port. Signed-off-by: Tejas Pandey --- inc/saiport.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/saiport.h b/inc/saiport.h index 705cfa39e..2658c83d9 100644 --- a/inc/saiport.h +++ b/inc/saiport.h @@ -2688,7 +2688,7 @@ typedef enum _sai_port_attr_t SAI_PORT_ATTR_PAM4_EYE_VALUES, /** - * @brief Get port firmware revision + * @brief Get port SerDes firmware revision * * Standard attribute to collect port SerDes firmware rev. *