Skip to content

Improving and changing images from the Tracks sections #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 10, 2025
Merged

Improving and changing images from the Tracks sections #600

merged 12 commits into from
Oct 10, 2025

Conversation

@SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Aug 5, 2025

No description provided.

@SeqLaz SeqLaz requested a review from beanzmo August 5, 2025 20:31
@duke-nyuki
Copy link

Task linked: QF-6296 Tracking - Revisit

beanzmo
beanzmo reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@beanzmo beanzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeqLaz can you check the numbered list I added. The list does not continue L34

@SeqLaz
Copy link
Member Author

SeqLaz commented Aug 12, 2025

@SeqLaz can you check the numbered list I added. The list does not continue L34

@beanzmo Fixed, it was needed to add a tab to the content in the middle of the ordered list.

m-kuhn
m-kuhn reviewed Aug 13, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Aug 14, 2025
View reviewed changes
beanzmo
beanzmo reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@beanzmo beanzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirvn please have a look

nirvn
nirvn reviewed Aug 28, 2025
View reviewed changes
Copy link
Member

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review left.

One more thing beyond what I said: we should settle on whether we want the phone screenshots to be landscape or portrait. Landscape IMHO looks a bit better (certainly so on desktop), and allows for easier skimming through a given page.

beanzmo
beanzmo approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@beanzmo beanzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO from my point it is clear and I aprove this

@beanzmo beanzmo requested review from m-kuhn and nirvn August 28, 2025 14:29
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
m-kuhn
m-kuhn reviewed Sep 29, 2025
View reviewed changes
@m-kuhn m-kuhn marked this pull request as draft September 29, 2025 09:23
@m-kuhn
Copy link
Member

m-kuhn commented Sep 29, 2025

Converting to draft so I know when to look at this again

@beanzmo
Copy link
Contributor

beanzmo commented Sep 29, 2025

@SeqLaz once again - i cannot fix the table form to continue with its numbers.

@beanzmo beanzmo requested a review from m-kuhn October 1, 2025 15:28
@SeqLaz
Copy link
Member Author

SeqLaz commented Oct 8, 2025

@beanzmo In the last two commit I fixed the number order, and the conflicts!

@SeqLaz SeqLaz requested a review from beanzmo October 8, 2025 06:41
@beanzmo beanzmo marked this pull request as ready for review October 10, 2025 13:59
@beanzmo beanzmo merged commit 121996e into master Oct 10, 2025
3 checks passed
@beanzmo beanzmo deleted the QF-6296-tracking_revisit branch October 10, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirvn nirvn Awaiting requested review from nirvn

@m-kuhn m-kuhn Awaiting requested review from m-kuhn

@beanzmo beanzmo Awaiting requested review from beanzmo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SeqLaz @duke-nyuki @m-kuhn @beanzmo @nirvn