bugfix: mark committed to false only when it is nil in conn

Author: taoky

lib/resty/limit/conn.lua

@@ -46,7 +46,9 @@ function _M.incoming(self, key, commit)
     local dict = self.dict
     local max = self.max
 
-    self.committed = false
+    if self.committed == nil then
+        self.committed = false
+    end
 
     local conn, err
     if commit then

t/conn.t

@@ -285,3 +285,43 @@ failed to limit conn: rejected
 --- no_error_log
 [error]
 [lua]
+
+
+
+=== TEST 6: incoming dry run shall not modify committed state
+--- http_config eval
+"
+$::HttpConfig
+
+    lua_shared_dict store 1m;
+"
+--- config
+    location = /t {
+        content_by_lua_block {
+            local limit_conn = require "resty.limit.conn"
+            local lim = limit_conn.new("store", 2, 1, 1)
+            ngx.shared.store:flush_all()
+            local key = "foo"
+
+            local delay, err = lim:incoming(key, true)
+            if not delay then
+                ngx.say("failed to limit conn: ", err)
+            end
+            delay, err = lim:incoming(key, false)
+            if not delay then
+                ngx.say("failed to limit conn: ", err)
+            end
+            if not lim:is_committed() then
+                ngx.say("not committed")
+            else
+                ngx.say("committed")
+            end
+        }
+    }
+--- request
+    GET /t
+--- response_body
+committed
+--- no_error_log
+[error]
+[lua]