Address agentzh's comments.

Author: lziest

README.markdown

@@ -1465,8 +1465,11 @@ ngx-ssl-session-ticket-keys
 Dumping ssl session ticket keys of a nginx worker.
 
 ```bash
+# making the ./stap++ tool visible in PATH:
+$ export PATH=$PWD:$PATH
+
 # assuming one nginx worker process has the pid 3781.
-$ ./samples/ngx-ssl-session-ticket-keys.sxx -I ./tapset -x 3781
+$ ./samples/ngx-ssl-session-ticket-keys.sxx -x 3781
 ```
 
 [Back to TOC](#table-of-contents)
@@ -1477,6 +1480,9 @@ ngx-ssl-session-resumption-stats
 Analyzing the statistics of nginx SSL/TLS session ticket resumption.
 
 ```bash
+# making the ./stap++ tool visible in PATH:
+$ export PATH=$PWD:$PATH
+
 # assuming one nginx worker process has the pid 3781.
 $ ./samples/ngx-ssl-session-resumption-stats.sxx -x 3781
 ```

samples/ngx-ssl-session-resumption-stats.sxx

@@ -1,6 +1,6 @@
 #!/usr/bin/env stap++
 
-# Capture ssl session resumption statistics. 
+# Capture ssl session resumption statistics.
 
 global total
 global tickets
@@ -39,7 +39,7 @@ probe end {
         ratio2 = (resumed * 100) / tickets;
 
     } else {
-        ratio2 = 0;   
+        ratio2 = 0;
     }
     printf("Session resumption attempts ratio: %d percent\n", ratio1)
     printf("Session resumption success ratio: %d percent\n", ratio2)

samples/ngx-ssl-session-ticket-keys.sxx

@@ -3,7 +3,7 @@
 # Capture ssl session tickets.
 
 @use nginx.array
-@use nginx.openssl
+@use openssl
 
 probe begin {
     printf("Start tracing NGX OPENSSL ticket key callback\n")
@@ -14,7 +14,7 @@ function print_key_name(name) {
     printf("key name: ");
     $*n := @cast(name, "unsigned char", "$^exec_path")
     for (i=0; i<16; i++) {
-       printf("%02x", $*n[i]) 
+       printf("%02x", $*n[i])
     }
     printf("\n")
 }
@@ -24,7 +24,7 @@ function print_key_aes(state) {
     printf("key aes state: ");
     $*s := @cast(state, "unsigned char", "$^exec_path")
     for (i=0; i<16; i++) {
-       printf("%02x", $*s[i]) 
+       printf("%02x", $*s[i])
     }
     printf("\n")
 }
@@ -34,7 +34,7 @@ function print_key_hmac(state) {
     printf("key hmac state: ");
     $*s := @cast(state, "unsigned char", "$^exec_path")
     for (i=0; i<16; i++) {
-       printf("%02x", $*s[i]) 
+       printf("%02x", $*s[i])
     }
     printf("\n")
 }
@@ -63,7 +63,7 @@ probe @pfunc(ngx_ssl_session_ticket_key_callback).return {
         } else {
             key_ptr = get_ngx_array_elts(keys)
             enc_key = key_ptr
-            last_key = &@cast(key_ptr, "ngx_ssl_session_ticket_key_t", "$^exec_path")[keys_len-1] 
+            last_key = &@cast(key_ptr, "ngx_ssl_session_ticket_key_t", "$^exec_path")[keys_len-1]
             printf("keys len %d\n", keys_len)
             printf("enc key:\n")
             print_session_ticket_key(enc_key)

tapset/nginx/array.sxx

@@ -3,7 +3,7 @@
 function get_ngx_array_len(ngx_arr) {
     $*arr := @cast(ngx_arr, "ngx_array_t", "$^exec_path")
     return $*arr->nelts
-    
+
 }
 
 function get_ngx_array_elts(ngx_arr) {

tapset/nginx/openssl.sxx renamed to tapset/openssl.sxx

@@ -1,4 +1,4 @@
-// module nginx.openssl
+// module openssl.ssl_ctx
 
 // extract ex_data pointer from openssl SSL_CTX
 function get_ssl_ex_data(ssl_ctx) {
@@ -9,11 +9,13 @@ function get_ssl_ex_data(ssl_ctx) {
 // extract number of items in SSL_CTX ex_data
 function get_ssl_ex_data_len(ssl_ctx) {
     ex_data = get_ssl_ex_data(ssl_ctx)
-    return ex_data->sk->stack->num
+    $*data := @cast(ex_data, "CRYPTO_EX_DATA", "$^exec_path")
+    return $*data->sk->stack->num
 }
 
 // extract the item specified by idx in SSL_CTX ex_data
 function get_ssl_ex_data_item(ssl_ctx, idx) {
     ex_data = get_ssl_ex_data(ssl_ctx)
-    return ex_data->sk->stack->data[idx]
+    $*data := @cast(ex_data, "CRYPTO_EX_DATA", "$^exec_path")
+    return $*data->sk->stack->data[idx]
 }