Include check that from timestamp is before to timestamp (#413)

Signed-off-by: Emily Guo <[email protected]>

Author: LilyCaroline17

src/main/java/org/opensearch/plugin/insights/rules/resthandler/top_queries/RestTopQueriesAction.java

@@ -120,6 +120,17 @@ private static void validateTimeRange(RestRequest request, String from, String t
                 )
             );
         }
+        if (ZonedDateTime.parse(from).isAfter(ZonedDateTime.parse(to))) {
+            throw new IllegalArgumentException(
+                String.format(
+                    Locale.ROOT,
+                    "request [%s] contains invalid time range. 'from' date [%s] must be before 'to' date [%s]",
+                    request.path(),
+                    from,
+                    to
+                )
+            );
+        }
     }
 
     @Override

src/test/java/org/opensearch/plugin/insights/rules/resthandler/top_queries/RestTopQueriesActionTests.java

@@ -90,6 +90,27 @@ public void testInValidTo() {
         );
     }
 
+    public void testFromAfterTo() {
+        Map<String, String> params = new HashMap<>();
+        ZonedDateTime now = ZonedDateTime.now(ZoneOffset.UTC);
+        String from = now.plusHours(1).format(DateTimeFormatter.ISO_DATE_TIME);
+        String to = now.format(DateTimeFormatter.ISO_DATE_TIME);
+        params.put("from", from);
+        params.put("to", to);
+        RestRequest restRequest = buildRestRequest(params);
+        Exception exception = assertThrows(IllegalArgumentException.class, () -> { RestTopQueriesAction.prepareRequest(restRequest); });
+        assertEquals(
+            String.format(
+                Locale.ROOT,
+                "request [%s] contains invalid time range. 'from' date [%s] must be before 'to' date [%s]",
+                restRequest.path(),
+                from,
+                to
+            ),
+            exception.getMessage()
+        );
+    }
+
     public void testMissingOneTimeParam() {
         Map<String, String> params = new HashMap<>();
         params.put("from", ZonedDateTime.now(ZoneOffset.UTC).format(DateTimeFormatter.ISO_DATE_TIME));