Skip to content

Conversation

@bradbehle
Copy link
Contributor

This logging configuration is not used and not needed. It should be removed so it does not cause confusion.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2025
@openshift-ci-robot
Copy link
Contributor

@bradbehle: This pull request references CORENET-6465 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This logging configuration is not used and not needed. It should be removed so it does not cause confusion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

Hi @bradbehle. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 13, 2025

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradbehle, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
This logging configuration is not used and not needed.  It should be
removed so it does not cause confusion
@bradbehle bradbehle force-pushed the remove-ovs-logging-config branch from cf4afbc to ce47039 Compare November 6, 2025 18:36
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

New changes are detected. LGTM label has been removed.

@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Walkthrough

Removed the logging configuration block from the gateway section in the OVN-Kubernetes managed configuration file, eliminating libovsdblogfile, logfile-maxsize, logfile-maxbackups, and logfile-maxage keys.

Changes

Cohort / File(s) Summary
OVN-Kubernetes Logging Configuration
bindata/network/ovn-kubernetes/managed/004-config.yaml
Removed [logging] configuration block under [gateway] section; eliminated libovsdblogfile, logfile-maxsize, logfile-maxbackups, and logfile-maxage parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that removing these logging parameters does not impact gateway service startup or operational logging requirements
  • Confirm there are no downstream dependencies or monitoring systems relying on these specific log file paths or rotation settings
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 05d6f46 and ce47039.

📒 Files selected for processing (1)
  • bindata/network/ovn-kubernetes/managed/004-config.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • bindata/network/ovn-kubernetes/managed/004-config.yaml

Comment @coderabbitai help to get the list of available commands and usage tips.

@bradbehle
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

@bradbehle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security ce47039 link false /test security
ci/prow/4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade ce47039 link false /test 4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade ce47039 link false /test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
ci/prow/4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade ce47039 link false /test 4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn ce47039 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-ovn ce47039 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants