Skip to content

Commit 971ed2f

Browse files
committed
[improvement] Ruby 3.2 support (3m)
1 parent 5699af7 commit 971ed2f

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
10-
ruby-version: [ "2.3", "2.4", "2.5", "2.6", "2.7", "3.0" ]
10+
ruby-version: [ "3.0", "3.1", "3.2", "3.3", "3.4" ]
1111

1212
steps:
1313
- name: Checkout

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,4 @@ test/version_tmp
2222
*.o
2323
*.a
2424
mkmf.log
25+
.DS_Store

lib/openxml/has_attributes.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def valid_in?(value, list)
162162
end
163163

164164
def matches?(value, regexp)
165-
return if value =~ regexp
165+
return if value.is_a?(String) && value =~ regexp
166166
raise ArgumentError, "Value does not match #{regexp}"
167167
end
168168

test/has_children_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def render?
3535
end
3636

3737
should "call to_xml on all of its children" do
38-
child = MiniTest::Mock.new
38+
child = Minitest::Mock.new
3939
child.expect :to_xml, "xml", %w{ xml }
4040
element << child
4141
element.to_xml "xml"

test/has_properties_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,9 @@ def tag
130130
end
131131

132132
should "call to_xml on each property" do
133-
builder = Nokogiri::XML::Builder.new
134-
mock = MiniTest::Mock.new
135-
def mock.render?; true; end
133+
builder = OpenXml::Builder.new
134+
mock = Minitest::Mock.new
135+
mock.expect(:render?, true)
136136
mock.expect(:to_xml, nil, [ builder ])
137137

138138
OpenXml::Properties::BooleanProperty.stub :new, mock do

test/test_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
require "rr"
1010

1111
require "minitest/reporters/turn_reporter"
12-
MiniTest::Reporters.use! Minitest::Reporters::TurnReporter.new
12+
Minitest::Reporters.use! Minitest::Reporters::TurnReporter.new
1313

1414
require "shoulda/context"
1515
require "pry"

0 commit comments

Comments
 (0)