Skip to content

Commit edef963

Browse files
authored
allow overriding ci comment (#2871)
1 parent 4e6deda commit edef963

File tree

10 files changed

+14
-11
lines changed

10 files changed

+14
-11
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "openapi-workspaces",
33
"license": "MIT",
44
"private": true,
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"workspaces": [
77
"projects/json-pointer-helpers",
88
"projects/openapi-io",

projects/fastify-capture/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@useoptic/fastify-capture",
33
"license": "MIT",
44
"packageManager": "[email protected]",
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"main": "build/index.js",
77
"types": "build/index.d.ts",
88
"files": [

projects/json-pointer-helpers/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@useoptic/json-pointer-helpers",
33
"license": "MIT",
44
"packageManager": "[email protected]",
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"main": "build/index.js",
77
"types": "build/index.d.ts",
88
"files": [

projects/openapi-io/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@useoptic/openapi-io",
33
"license": "MIT",
44
"packageManager": "[email protected]",
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"main": "build/index.js",
77
"types": "build/index.d.ts",
88
"files": [

projects/openapi-utilities/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@useoptic/openapi-utilities",
33
"license": "MIT",
44
"packageManager": "[email protected]",
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"main": "build/index.js",
77
"types": "build/index.d.ts",
88
"files": [

projects/optic/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@useoptic/optic",
33
"license": "MIT",
44
"packageManager": "[email protected]",
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"main": "build/index.js",
77
"types": "build/index.d.ts",
88
"files": [

projects/optic/src/commands/ci/comment/comment.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export const registerCiComment = (cli: Command, config: OpticCliConfig) => {
5151
'--enterprise-base-url <enterprise-base-url>',
5252
'(only for enterprise versions of github or gitlab) - the base url to your enterprise github / gitlab instance'
5353
)
54+
.option('--comment-url <comment-url>', 'override the url of the comment')
5455
.option('--verbose', 'show all operations changed in each API', false)
5556
.description('comment on a pull request / merge request')
5657
.action(
@@ -60,6 +61,7 @@ export const registerCiComment = (cli: Command, config: OpticCliConfig) => {
6061

6162
type CommonOptions = {
6263
verbose: boolean;
64+
commentUrl: string;
6365
};
6466

6567
type UnvalidatedOptions = CommonOptions & {
@@ -153,6 +155,7 @@ const getCiCommentAction =
153155
await commenter.getComment(COMPARE_SUMMARY_IDENTIFIER);
154156
const body = generateCompareSummaryMarkdown({ sha: options.sha }, data, {
155157
verbose: options.verbose,
158+
overrideUrl: options.commentUrl,
156159
});
157160

158161
if (maybeComment) {

projects/optic/src/commands/ci/comment/common.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const getCaptureIssuesLabel = ({
8282
export const generateCompareSummaryMarkdown = (
8383
commit: { sha: string },
8484
results: CiRunDetails,
85-
options: { verbose: boolean }
85+
options: { verbose: boolean; overrideUrl?: string }
8686
) => {
8787
const anyCompletedHasWarning = results.completed.some(
8888
(s) => s.warnings.length > 0
@@ -122,7 +122,7 @@ ${s.apiName}
122122
<td>
123123
124124
${getOperationsText(s.comparison.groupedDiffs, {
125-
webUrl: s.opticWebUrl,
125+
webUrl: options.overrideUrl || s.opticWebUrl,
126126
verbose: options.verbose,
127127
labelJoiner: ',\n',
128128
})}
@@ -163,7 +163,7 @@ ${
163163
164164
<td>
165165
166-
${s.opticWebUrl ? `[View report](${s.opticWebUrl})` : ''}
166+
${options.overrideUrl || s.opticWebUrl ? `[View report](${options.overrideUrl || s.opticWebUrl})` : ''}
167167
168168
</td>
169169
</tr>`

projects/rulesets-base/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@useoptic/rulesets-base",
33
"license": "MIT",
44
"packageManager": "[email protected]",
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"main": "build/index.js",
77
"types": "build/index.d.ts",
88
"files": [

projects/standard-rulesets/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@useoptic/standard-rulesets",
33
"license": "MIT",
44
"packageManager": "[email protected]",
5-
"version": "1.0.4",
5+
"version": "1.0.5",
66
"main": "build/index.js",
77
"types": "build/index.d.ts",
88
"files": [

0 commit comments

Comments
 (0)