-
Notifications
You must be signed in to change notification settings - Fork 47
Implementation of backend plotting for slice_plot
#649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
f6c8e5d to
aa76f21
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
aa76f21 to
9ec8b9a
Compare
timmens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, thank you!! I only have a few minor comments, which I why I already approve.
Can you also check out the failures; although I think they are unrelated to your changes -- in that case; you can ignore them.
Summary of changes
slice_plotby separating data extraction logic from plotting code.MarkerDatadataclass.Plot Changes
The only change is with the horizontal and vertical spacing.
Backend Comparision
PR Checklist