Skip to content

Conversation

@r3kste
Copy link
Collaborator

@r3kste r3kste commented Oct 29, 2025

Summary of changes

  1. Refactored slice_plot by separating data extraction logic from plotting code.
  2. Added new parameters for range and share_axes, and vectorized labels in grid_plot.
  3. Introduced MarkerData dataclass.

Plot Changes

Before After
oldplot newplot

The only change is with the horizontal and vertical spacing.

Backend Comparision

Plotly Matplotlib
oldplot slice_plot

PR Checklist

  • Compared images before and after making changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 97.14286% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/optimagic/deprecations.py 33.33% 2 Missing ⚠️
src/optimagic/visualization/slice_plot.py 98.59% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/optimagic/visualization/backends.py 99.02% <100.00%> (+0.23%) ⬆️
src/optimagic/visualization/convergence_plot.py 95.45% <ø> (ø)
src/optimagic/visualization/plotting_utilities.py 52.50% <100.00%> (-40.97%) ⬇️
src/optimagic/visualization/slice_plot.py 96.12% <98.59%> (+1.17%) ⬆️
src/optimagic/deprecations.py 98.17% <33.33%> (-0.91%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r3kste r3kste force-pushed the slice_plot_refactor branch from f6c8e5d to aa76f21 Compare October 30, 2025 19:19
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@r3kste r3kste force-pushed the slice_plot_refactor branch from aa76f21 to 9ec8b9a Compare October 30, 2025 19:56
@r3kste r3kste requested a review from timmens October 30, 2025 20:14
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thank you!! I only have a few minor comments, which I why I already approve.

Can you also check out the failures; although I think they are unrelated to your changes -- in that case; you can ignore them.

@r3kste r3kste merged commit 4628a47 into optimagic-dev:main Nov 11, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants