WIP: Batch load and save test case added

Author: muzahidul-opti

Sources/Implementation/DefaultDecisionService.swift

@@ -111,8 +111,8 @@ class DefaultDecisionService: OPTDecisionService {
         }
 
         /// Load variation from tracker
-        if let _userId = userProfileTracker?.userId,
-           let variationId = getVariationIdFromProfile(userId: _userId, experimentId: experimentId),
+        if let profile = userProfileTracker?.userProfile,
+           let variationId = getVariationIdFromProfile(profile: profile, experimentId: experimentId),
            let variation = experiment.getVariation(id: variationId) {
 
             let info = LogMessage.gotVariationFromUserProfile(variation.key, experiment.key, userId)
@@ -226,35 +226,6 @@ class DefaultDecisionService: OPTDecisionService {
         }
 
         return response!
-        
-        
-        
-//        // Evaluate in this order:
-//        
-//        // 1. Attempt to bucket user into experiment using feature flag.
-//        // Check if the feature flag is under an experiment and the the user is bucketed into one of these experiments
-//        var decisionResponse = getVariationForFeatureExperiment(config: config,
-//                                                                featureFlag: featureFlag,
-//                                                                user: user,
-//                                                                userProfileTracker: nil,
-//                                                                options: options)
-//        reasons.merge(decisionResponse.reasons)
-//        if let decision = decisionResponse.result {
-//            return DecisionResponse(result: decision, reasons: reasons)
-//        }
-//        
-//        // 2. Attempt to bucket user into rollout using the feature flag.
-//        // Check if the feature flag has rollout and the user is bucketed into one of it's rules
-//        decisionResponse = getVariationForFeatureRollout(config: config,
-//                                                         featureFlag: featureFlag,
-//                                                         user: user,
-//                                                         options: options)
-//        reasons.merge(decisionResponse.reasons)
-//        if let decision = decisionResponse.result {
-//            return DecisionResponse(result: decision, reasons: reasons)
-//        }
-//        
-//        return DecisionResponse(result: nil, reasons: reasons)
     }
 
     func getVariationForFeatureList(config: ProjectConfig,
@@ -544,6 +515,18 @@ extension DefaultDecisionService {
         }
     }
 
+    func getVariationIdFromProfile(profile: UserProfile?,
+                                   experimentId: String) -> String? {
+        if let _profile = profile,
+           let bucketMap = _profile[UserProfileKeys.kBucketMap] as? OPTUserProfileService.UPBucketMap,
+           let experimentMap = bucketMap[experimentId],
+           let variationId = experimentMap[UserProfileKeys.kVariationId] {
+            return variationId
+        } else {
+            return nil
+        }
+    }
+    
     func saveProfile(userId: String,
                      experimentId: String,
                      variationId: String) {

Tests/OptimizelyTests-Common/DecisionServiceTests_Features.swift

@@ -289,6 +289,61 @@ extension DecisionServiceTests_Features {
 
 }
 
+// MARK: - Test getVariationForFeatureList()
+
+extension DecisionServiceTests_Features {
+    func testGetVariationForFeatureListBatchUPSLoadAndSave() {
+        let mockProfileService = MocProfileService()
+        
+        let ups_service = DefaultDecisionService(userProfileService: mockProfileService)
+        
+        let flag1: FeatureFlag = try! OTUtils.model(
+            from:[
+                "id": "553339214",
+                "key": "house",
+                "experimentIds": [kExperimentId],
+                "rolloutId": "",
+                "variables": []
+            ]
+        )
+        
+        let flag2: FeatureFlag = try! OTUtils.model(
+            from:[
+                "id": "553339215",
+                "key": "house",
+                "experimentIds": [kExperimentId],
+                "rolloutId": "",
+                "variables": []
+            ]
+        )
+        
+        let flag3: FeatureFlag = try! OTUtils.model(
+            from:[
+                "id": "553339216",
+                "key": "house",
+                "experimentIds": [kExperimentId],
+                "rolloutId": "",
+                "variables": []
+            ]
+        )
+        
+        let pair = ups_service.getVariationForFeatureList(
+            config: config,
+            featureFlags: [flag1, flag2, flag3],
+            user:  optimizely.createUserContext(userId: kUserId,
+                                                attributes: kAttributesCountryMatch)
+        )
+        
+       
+        XCTAssertEqual(mockProfileService.lookupCount, 1)
+        XCTAssertEqual(mockProfileService.saveCount, 1)
+        XCTAssertEqual(pair.count, 3)
+        XCTAssert(pair[0].result?.experiment?.key == kExperimentKey)
+        XCTAssert(pair[0].result?.variation.key == kVariationKeyD)
+        XCTAssert(pair[0].result?.source == Constants.DecisionSource.featureTest.rawValue)
+    }
+}
+
 // MARK: - Test getVariationForFeatureRollout()
 
 extension DecisionServiceTests_Features {
@@ -466,3 +521,19 @@ extension DecisionServiceTests_Features {
     }
 
 }
+
+class MocProfileService: DefaultUserProfileService {
+    var lookupCount = 0
+    var saveCount = 0
+    
+    override func lookup(userId: String) -> DefaultUserProfileService.UPProfile? {
+        lookupCount += 1
+        return super.lookup(userId: userId)
+    }
+    
+    override func save(userProfile: DefaultUserProfileService.UPProfile) {
+        super.save(userProfile: userProfile)
+        saveCount += 1
+    }
+    
+}