Skip to content

Commit 0ca67d2

Browse files
committed
Prepare for release
1 parent 3b94a5a commit 0ca67d2

File tree

7 files changed

+33
-19
lines changed

7 files changed

+33
-19
lines changed

.github/scripts/check_diff.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import sys
33
from typing import Dict
44

5-
LIB_DIRS = ["libs/oci"]
5+
LIB_DIRS = ["libs/oci", "libs/oracledb"]
66

77
if __name__ == "__main__":
88
files = sys.argv[1:]

libs/oracledb/langchain_oracledb/document_loaders/oracleadb_loader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def __init__(
5353
:param wallet_password: password of wallet, not required for TLS connections
5454
:param metadata: metadata used in document
5555
:param parameter: bind variable to use in query
56-
"""
56+
""" # noqa: E501
5757
# Mandatory required arguments.
5858
self.query = query
5959
self.user = user

libs/oracledb/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "langchain-oracledb"
3-
version = "0.1.0"
3+
version = "1.0.1"
44
description = "An integration package connecting Oracle Database and LangChain"
55
authors = []
66
readme = "README.md"

libs/oracledb/tests/integration_tests/document_loaders/test_oracleds.py

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
"""
1111
import sys
1212

13+
import oracledb
14+
import pytest
15+
1316
from langchain_oracledb.document_loaders.oracleai import (
1417
OracleDocLoader,
1518
OracleTextSplitter,
@@ -24,14 +27,17 @@
2427
passwd = ""
2528
v_dsn = ""
2629

30+
try:
31+
oracledb.connect(user=uname, password=passwd, dsn=v_dsn)
32+
except Exception as e:
33+
pytest.skip(
34+
allow_module_level=True,
35+
reason=f"Database connection failed: {e}, skipping tests.",
36+
)
37+
2738

2839
### Test loader #####
2940
def test_loader_test() -> None:
30-
try:
31-
import oracledb
32-
except ImportError:
33-
return
34-
3541
try:
3642
# oracle connection
3743
connection = oracledb.connect(user=uname, password=passwd, dsn=v_dsn)
@@ -131,11 +137,6 @@ def test_loader_test() -> None:
131137

132138
### Test splitter ####
133139
def test_splitter_test() -> None:
134-
try:
135-
import oracledb
136-
except ImportError:
137-
return
138-
139140
try:
140141
# oracle connection
141142
connection = oracledb.connect(user=uname, password=passwd, dsn=v_dsn)
@@ -311,11 +312,6 @@ def test_splitter_test() -> None:
311312

312313
#### Test summary ####
313314
def test_summary_test() -> None:
314-
try:
315-
import oracledb
316-
except ImportError:
317-
return
318-
319315
try:
320316
# oracle connection
321317
connection = oracledb.connect(user=uname, password=passwd, dsn=v_dsn)
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Copyright (c) 2025 Oracle and/or its affiliates.
2+
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
3+
4+
import pytest
5+
6+
7+
@pytest.mark.compile
8+
def test_placeholder() -> None:
9+
"""Makes sure no errors raised when no tests selected."""
10+
pass

libs/oracledb/tests/integration_tests/vectorstores/test_oraclevs.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,14 @@
3939
password = ""
4040
dsn = ""
4141

42+
try:
43+
oracledb.connect(user=username, password=password, dsn=dsn)
44+
except Exception as e:
45+
pytest.skip(
46+
allow_module_level=True,
47+
reason=f"Database connection failed: {e}, skipping tests.",
48+
)
49+
4250

4351
############################
4452
####### table_exists #######

libs/oracledb/tests/unit_tests/document_loaders/test_oracleadb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def test_oracle_loader_load(mock_query: MagicMock) -> None:
5454
query="Test query",
5555
user="Test user",
5656
password="Test password",
57-
connection_string="Test connection string",
57+
dsn="Test connection string",
5858
metadata=["FIELD1"],
5959
)
6060

0 commit comments

Comments
 (0)