Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Commit f5bd5ce

Browse files
New Release v1.3.1 for OCI Service Broker
- Minor Bug Fixes Co-authored-by: Ashokkumar Kannan [email protected] Co-authored-by: Jayasheelan Kumar [email protected] Co-authored-by: Naman Mehta [email protected]
1 parent 46ff7c9 commit f5bd5ce

File tree

9 files changed

+20
-51
lines changed

9 files changed

+20
-51
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
66
This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
77

8+
[1.3.1]
9+
10+
- Minor Bug Fixes
11+
812
[1.3.0]
913

1014
- Adding support for Mumbai (BOM), Zurich (ZRH), Sao Paulo (GRU), Sydney (SYD) regions

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ See the [Documentation](charts/oci-service-broker/README.md#oci-service-broker)
2929
The OCI Service Broker is packaged as Helm chart for making it easy to install in Kubernetes Clusters. The chart can be downloaded from below URL.
3030

3131
```
32-
https://github.com/oracle/oci-service-broker/releases/download/v1.3.0/oci-service-broker-1.3.0.tgz
32+
https://github.com/oracle/oci-service-broker/releases/download/v1.3.1/oci-service-broker-1.3.1.tgz
3333
```
3434

3535
## Samples

charts/oci-service-broker/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
apiVersion: v1
66
description: A Helm chart for installing OCI Service Broker into a Kubernetes cluster
77
name: oci-service-broker
8-
version: 1.3.0
8+
version: 1.3.1

charts/oci-service-broker/docs/installation.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ brew update && brew install kubernetes-service-catalog-client
6969
The OCI Service Broker is packaged as Helm chart for making it easy to install in Kubernetes. The chart is available at [charts/oci-service-broker](../) directory.
7070

7171
```plain
72-
https://github.com/oracle/oci-service-broker/releases/download/v1.3.0/oci-service-broker-1.3.0.tgz
72+
https://github.com/oracle/oci-service-broker/releases/download/v1.3.1/oci-service-broker-1.3.1.tgz
7373
```
7474

7575
### OCI credentials
@@ -107,7 +107,7 @@ The value for `ociCredentials.secretName` should contain the name of the Kuberne
107107
For quickly testing out OCI Service Broker, TLS can be disabled and an embedded etcd container can be used. This can be used for quickly setting up the Broker but not recommended in PRODUCTION environments. Please refer to [Recommended Setup](#recommended-setup) for PRODUCTION environments
108108

109109
```bash
110-
helm install https://github.com/oracle/oci-service-broker/releases/download/v1.3.0/oci-service-broker-1.3.0.tgz --name oci-service-broker \
110+
helm install https://github.com/oracle/oci-service-broker/releases/download/v1.3.1/oci-service-broker-1.3.1.tgz --name oci-service-broker \
111111
--set ociCredentials.secretName=ocicredentials \
112112
--set storage.etcd.useEmbedded=true \
113113
--set tls.enabled=false
@@ -200,7 +200,7 @@ Please note that the names in keys i.e. keyStore.password and keyStore must not
200200

201201
Replace the values of --set arguments with your appropriate values to install the OCI Service Broker. User needs to point docker images either from OCIR or from their repository.
202202
```bash
203-
helm install https://github.com/oracle/oci-service-broker/releases/download/v1.3.0/oci-service-broker-1.3.0.tgz --name oci-service-broker \
203+
helm install https://github.com/oracle/oci-service-broker/releases/download/v1.3.1/oci-service-broker-1.3.1.tgz --name oci-service-broker \
204204
--set ociCredentials.secretName=ocicredentials \
205205
--set tls.secretName=certsecret \
206206
--set storage.etcd.servers=<comma separated list of etcd servers>
@@ -245,7 +245,7 @@ Refer [Restrict access to Service Catalog resources using RBAC](security.md#rest
245245
Sample files for various services are available under [`oci-service-broker/samples`](../samples) directory inside the charts. The below command extracts chart that contains the sample files.
246246

247247
```bash
248-
curl https://github.com/oracle/oci-service-broker/releases/download/v1.3.0/oci-service-broker-1.3.0.tgz | tar xz
248+
curl https://github.com/oracle/oci-service-broker/releases/download/v1.3.1/oci-service-broker-1.3.1.tgz | tar xz
249249
```
250250

251251
Create a `ClusterServiceBroker` resource with OCI Service Broker URL to register the broker. Use the below register yaml file after updating the namespace of the OCI Service Broker.

charts/oci-service-broker/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ image:
1414
repository: iad.ocir.io/oracle/oci-service-broker
1515

1616
# Tag of the image
17-
tag: 1.3.0
17+
tag: 1.3.1
1818

1919
# The image pull policy
2020
pullPolicy: Always

oci-service-broker/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ apply plugin: 'maven-publish'
3030
archivesBaseName = 'oci-service-broker'
3131

3232
// Sometimes, the version has to be overridden from command line
33-
version = project.hasProperty('version_num') ? project.getProperty('version_num') : '1.3.0'
33+
version = project.hasProperty('version_num') ? project.getProperty('version_num') : '1.3.1'
3434
ext.dockerGroup = 'iad.ocir.io/oci-cnp-dev'
3535
mainClassName = 'com.oracle.oci.osb.Broker'
3636

oci-service-broker/src/main/java/com/oracle/oci/osb/model/Extra.java

Lines changed: 0 additions & 40 deletions
This file was deleted.

oci-service-broker/src/main/java/com/oracle/oci/osb/model/Identity.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import com.fasterxml.jackson.annotation.JsonProperty;
1010

1111
import java.util.List;
12+
import java.util.Map;
1213

1314
@JsonInclude(JsonInclude.Include.NON_NULL)
1415
public class Identity {
@@ -20,7 +21,7 @@ public class Identity {
2021
@JsonProperty("groups")
2122
private List<String> groups = null;
2223
@JsonProperty("extra")
23-
private Extra extra;
24+
private Map<String,List<String>> extra;
2425

2526
@JsonProperty("username")
2627
public String getUsername() {
@@ -53,12 +54,12 @@ public void setGroups(List<String> groups) {
5354
}
5455

5556
@JsonProperty("extra")
56-
public Extra getExtra() {
57+
public Map<String,List<String>> getExtra() {
5758
return extra;
5859
}
5960

6061
@JsonProperty("extra")
61-
public void setExtra(Extra extra) {
62+
public void setExtra(Map<String,List<String>> extra) {
6263
this.extra = extra;
6364
}
6465
}

oci-service-broker/src/main/java/com/oracle/oci/osb/rest/RequestValidationFilter.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,11 @@ private void validAPIVersion(ContainerRequestContext ctx) {
6363
//Ignore as error will be thrown further down.
6464
}
6565
}
66+
LOGGER.fine("Invalid value for Broker API version: " + version);
6667
abortWithError(ctx, Errors.brokerAPIVersionHeaderInvalid(),
6768
"Invalid value for Broker API version: " + version);
6869
} else {
70+
LOGGER.fine("Broker API Version header missing in request");
6971
abortWithError(ctx, Errors.brokerAPIVersionHeaderMissing(),
7072
"Broker API Version header missing in request");
7173
}
@@ -78,11 +80,13 @@ private void setOriginatingEntity(ContainerRequestContext ctx) {
7880
}
7981
String originatingIdentity = ctx.getHeaderString(Constants.IDENTITY_HEADER);
8082
if (originatingIdentity == null) {
83+
LOGGER.fine("Broker Originating Identity header missing in request");
8184
abortWithError(ctx, Errors.brokerOriginatingIdentityHeaderMissing(),
8285
"Broker Originating Identity header missing in request");
8386
}
8487
Identity identity = parseIdentity(originatingIdentity);
8588
if (identity == null) {
89+
LOGGER.fine("Invalid value for header Broker Originating Identity: " + originatingIdentity);
8690
abortWithError(ctx, Errors.brokerOriginatingIdentityHeaderInvalid(),
8791
"Invalid value for Broker Originating Identity: " + originatingIdentity);
8892
}

0 commit comments

Comments
 (0)