From bd6e4bbbe8ecfd95fb871fb02dc1ae13c53e5e89 Mon Sep 17 00:00:00 2001
From: Adrian Brandemuehl <abrandemuehl@gmail.com>
Date: Mon, 18 Nov 2019 16:01:07 +0100
Subject: [PATCH] Warn user if updating wrong settings after setup

Some settings can't be updated after calling `setup`, now users will be
warned if they try to do so after `setup`
---
 osqp_mex.cpp | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/osqp_mex.cpp b/osqp_mex.cpp
index 01989f4..c1bb45c 100755
--- a/osqp_mex.cpp
+++ b/osqp_mex.cpp
@@ -1153,6 +1153,38 @@ void copyUpdatedSettingsToWork(const mxArray* mxPtr ,OsqpData* osqpData){
   //settings in the osqp workspace.  Protects against bad parameter writes
   //or future modifications to updated settings handling
 
+  // Warn the user if they try to update a parameter that cannot be updated
+  // after setup.
+  if((c_float)mxGetScalar(
+        mxGetField(mxPtr, 0, "sigma")) != osqpData->work->settings->sigma) {
+      mexWarnMsgTxt("sigma is not updateable after calling setup. Ignoring");
+  }
+  if((enum linsys_solver_type)(c_int)mxGetScalar(
+        mxGetField(mxPtr, 0, "linsys_solver")) !=
+          osqpData->work->settings->linsys_solver) {
+      mexWarnMsgTxt("linsys_solver is not updateable after calling setup. Ignoring");
+  }
+  if((c_int)mxGetScalar(mxGetField(mxPtr, 0, "scaling")) !=
+        osqpData->work->settings->scaling) {
+      mexWarnMsgTxt("scaling is not updateable after calling setup. Ignoring");
+  }
+  if((c_int)mxGetScalar(mxGetField(mxPtr, 0, "adaptive_rho")) !=
+          osqpData->work->settings->adaptive_rho) {
+      mexWarnMsgTxt("adaptive_rho is not updateable after calling setup. Ignoring");
+  }
+  if((c_int)mxGetScalar(mxGetField(mxPtr, 0, "adaptive_rho_interval")) !=
+          osqpData->work->settings->adaptive_rho_interval) {
+      mexWarnMsgTxt("adaptive_rho_interval is not updateable after calling setup. Ignoring");
+  }
+  if((c_float)mxGetScalar(mxGetField(mxPtr, 0, "adaptive_rho_tolerance")) !=
+          osqpData->work->settings->adaptive_rho_tolerance) {
+      mexWarnMsgTxt("adaptive_rho_tolerance is not updateable after calling setup. Ignoring");
+  }
+  if((c_float)mxGetScalar(mxGetField(mxPtr, 0, "adaptive_rho_fraction")) !=
+          osqpData->work->settings->adaptive_rho_fraction) {
+      mexWarnMsgTxt("adaptive_rho_fraction is not updateable after calling setup. Ignoring");
+  }
+
   osqp_update_max_iter(osqpData->work,
     (c_int)mxGetScalar(mxGetField(mxPtr, 0, "max_iter")));
   osqp_update_eps_abs(osqpData->work,