Add native_constant_invocation CS rules

Author: Jeremiah VALERIE

.php_cs.dist

@@ -18,6 +18,8 @@ return PhpCsFixer\Config::create()
             'binary_operator_spaces' => ['align_double_arrow' => false, 'align_equals' => false],
             'general_phpdoc_annotation_remove' => ['author', 'category', 'copyright', 'created', 'license', 'package', 'since', 'subpackage', 'version'],
             'native_function_invocation' => true,
+            'fully_qualified_strict_types' => true,
+            'native_constant_invocation' => true,
         ]
     )
     ->setFinder($finder)

src/Config/Processor/BuilderProcessor.php

@@ -101,7 +101,7 @@ private static function processFieldBuilders(array $fields)
                 @\trigger_error(
                     'The builder short syntax (Field: Builder => Field: {builder: Builder}) is deprecated as of 0.7 and will be removed in 0.12. '.
                     'It will be replaced by the field type short syntax (Field: Type => Field: {type: Type})',
-                    E_USER_DEPRECATED
+                    \E_USER_DEPRECATED
                 );
                 $fieldBuilderName = $field;
             }
@@ -151,7 +151,7 @@ private static function getBuilder($name, $type)
         if (isset($builderClassMap[$newName])) {
             @\trigger_error(
                 \sprintf('The "%s" %s builder is deprecated as of 0.7 and will be removed in 0.12. Use "%s" instead.', $name, $type, $newName),
-                E_USER_DEPRECATED
+                \E_USER_DEPRECATED
             );
 
             return $builders[$type][$newName] = new $builderClassMap[$newName]();

src/Definition/ConfigProcessor/PublicFieldsFilterConfigProcessor.php

@@ -19,7 +19,7 @@ function ($field, $fieldName) {
 
                 return $exposed;
             },
-            ARRAY_FILTER_USE_BOTH
+            \ARRAY_FILTER_USE_BOTH
         );
     }
 

src/DependencyInjection/Compiler/TaggedServiceMappingPass.php

@@ -111,7 +111,7 @@ function ($methodCall) {
                     'Autowire method "%s::setContainer" for custom tagged (type, resolver or mutation) services is deprecated as of 0.9 and will be removed in 1.0.',
                     ContainerAwareInterface::class
                 ),
-                E_USER_DEPRECATED
+                \E_USER_DEPRECATED
             );
             $solutionDefinition->addMethodCall('setContainer', [new Reference('service_container')]);
         }

src/Request/BatchParser.php

@@ -58,7 +58,7 @@ private function getParsedBody(Request $request)
             case static::CONTENT_TYPE_JSON:
                 $parsedBody = \json_decode($request->getContent(), true);
 
-                if (JSON_ERROR_NONE !== \json_last_error()) {
+                if (\JSON_ERROR_NONE !== \json_last_error()) {
                     throw new BadRequestHttpException('POST body sent invalid JSON');
                 }
                 break;

src/Request/Parser.php

@@ -49,7 +49,7 @@ private function getParsedBody(Request $request)
 
                 $parsedBody = \json_decode($body, true);
 
-                if (JSON_ERROR_NONE !== \json_last_error()) {
+                if (\JSON_ERROR_NONE !== \json_last_error()) {
                     throw new BadRequestHttpException('POST body sent invalid JSON');
                 }
                 break;
@@ -106,7 +106,7 @@ private function getParams(Request $request, array $data = [])
         if (\is_string($variables)) {
             $variables = \json_decode($variables, true);
 
-            if (JSON_ERROR_NONE !== \json_last_error()) {
+            if (\JSON_ERROR_NONE !== \json_last_error()) {
                 throw new BadRequestHttpException('Variables are invalid JSON');
             }
         }