Tests: Abstracting TestKernel

Author: renatomefi

Tests/DependencyInjection/OverblogGraphiQLExtensionTest.php

@@ -53,8 +53,8 @@ private function createContainer()
 
     private function compileContainer(ContainerBuilder $container)
     {
-        $container->getCompilerPassConfig()->setOptimizationPasses(array());
-        $container->getCompilerPassConfig()->setRemovingPasses(array());
+        $container->getCompilerPassConfig()->setOptimizationPasses([]);
+        $container->getCompilerPassConfig()->setRemovingPasses([]);
         $container->compile();
     }
 }

Tests/Fixtures/TestKernel.php

@@ -3,19 +3,14 @@
 namespace Overblog\GraphiQLBundle\Tests\Fixtures;
 
 use Overblog\GraphiQLBundle\OverblogGraphiQLBundle;
+use Overblog\GraphiQLBundle\Tests\TestKernel as AbstractTestKernel;
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
 use Symfony\Bundle\TwigBundle\TwigBundle;
 use Symfony\Component\Config\Loader\LoaderInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\HttpKernel\Kernel;
 
-final class TestKernel extends Kernel
+final class TestKernel extends AbstractTestKernel
 {
-    private $testCase;
-
-    /**
-     * {@inheritdoc}
-     */
     public function registerBundles()
     {
         return [
@@ -25,34 +20,8 @@ public function registerBundles()
         ];
     }
 
-    public function __construct($environment, $debug, $testCase = null)
-    {
-        $this->testCase = null !== $testCase ? $testCase : false;
-        parent::__construct($environment, $debug);
-    }
-
-    public function getCacheDir()
-    {
-        return sys_get_temp_dir().'/OverblogGraphQLBundle/'.Kernel::VERSION.'/'.$this->testCase.'/cache/'.$this->environment;
-    }
-
-    public function getLogDir()
-    {
-        return sys_get_temp_dir().'/OverblogGraphQLBundle/'.Kernel::VERSION.'/'.$this->testCase.'/logs';
-    }
-
-    public function getRootDir()
-    {
-        return __DIR__;
-    }
-
-    public function isBooted()
-    {
-        return $this->booted;
-    }
-
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
@@ -62,7 +31,7 @@ public function registerContainerConfiguration(LoaderInterface $loader)
                 'test' => true,
                 'templating' => ['engine' => ['twig']],
                 'assets' => ['enabled' => false],
-                'router' => ['resource' => '%kernel.root_dir%/../../Resources/config/routing.xml'],
+                'router' => ['resource' => '%kernel.root_dir%/../Resources/config/routing.xml'],
             ]);
         });
     }

Tests/Integration/OverblogGraphQLBundle/Fixtures/TestKernel.php

@@ -4,19 +4,14 @@
 
 use Overblog\GraphiQLBundle\OverblogGraphiQLBundle;
 use Overblog\GraphQLBundle\OverblogGraphQLBundle;
+use Overblog\GraphiQLBundle\Tests\TestKernel as AbstractTestKernel;
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
 use Symfony\Bundle\TwigBundle\TwigBundle;
 use Symfony\Component\Config\Loader\LoaderInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\HttpKernel\Kernel;
 
-final class TestKernel extends Kernel
+final class TestKernel extends AbstractTestKernel
 {
-    private $testCase;
-
-    /**
-     * {@inheritdoc}
-     */
     public function registerBundles()
     {
         return [
@@ -27,32 +22,6 @@ public function registerBundles()
         ];
     }
 
-    public function __construct($environment, $debug, $testCase = null)
-    {
-        $this->testCase = null !== $testCase ? $testCase : false;
-        parent::__construct($environment, $debug);
-    }
-
-    public function getCacheDir()
-    {
-        return sys_get_temp_dir().'/OverblogGraphQLBundle/'.Kernel::VERSION.'/'.$this->testCase.'/cache/'.$this->environment;
-    }
-
-    public function getLogDir()
-    {
-        return sys_get_temp_dir().'/OverblogGraphQLBundle/'.Kernel::VERSION.'/'.$this->testCase.'/logs';
-    }
-
-    public function getRootDir()
-    {
-        return __DIR__;
-    }
-
-    public function isBooted()
-    {
-        return $this->booted;
-    }
-
     /**
      * {@inheritdoc}
      */
@@ -65,7 +34,7 @@ public function registerContainerConfiguration(LoaderInterface $loader)
                 'templating' => ['engine' => ['twig']],
                 'assets' => ['enabled' => false],
                 'router' => [
-                    'resource' => '%kernel.root_dir%/Resources/config/routing.xml',
+                    'resource' => __DIR__ . '/Resources/config/routing.xml',
                 ],
             ]);
         });

Tests/TestKernel.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace Overblog\GraphiQLBundle\Tests;
+
+use Symfony\Component\HttpKernel\Kernel;
+
+abstract class TestKernel extends Kernel
+{
+    private $testCase;
+
+    public function __construct($environment, $debug, $testCase = null)
+    {
+        $this->testCase = null !== $testCase ? $testCase : false;
+        parent::__construct($environment, $debug);
+    }
+
+    public function getCacheDir()
+    {
+        return sys_get_temp_dir().'/OverblogGraphQLBundle/'.Kernel::VERSION.'/'.$this->testCase.'/cache/'.$this->environment;
+    }
+
+    public function getLogDir()
+    {
+        return sys_get_temp_dir().'/OverblogGraphQLBundle/'.Kernel::VERSION.'/'.$this->testCase.'/logs';
+    }
+
+    public function getRootDir()
+    {
+        return __DIR__;
+    }
+
+    public function isBooted()
+    {
+        return $this->booted;
+    }
+}