Use has_broken as a is_valid check function #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add feature flag to use has_broken as valid check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bb8::ConnectionManager has is_valid and has_broken methods. In make_pooled, there is no option to use has_broken.
Introducing a feature flag called
use_has_broken_as_valid_check, with this feature flag, the is_valid method of bb8::ConnectionManager uses the has_broken method of r2d2's ManageConnection.For Diesel, the has_broken method uses the is_broken method of Diesel Connection. 'Select 1' can be avoided for every get from the connection pool.