psu_seq: refactor ereports to use microcbor
#2284
Merged
+97
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2246 introduced the `microcbor` crate for derivable CBOR serialization with a fixed max length. That branch changed the ereports in `drv_gimlet_seq_server` to use the new derives. The intent at the time was to update other existing ereports, such as those in `drv_psc_seq_server`, separately. This branch does that.
hawkw
added
psc
mkeeter
reviewed
Nov 13, 2025
| pub(super) struct EreportFields { | ||
| pub(super) refdes: FixedStr<20>, // Component ID max length | ||
| pub(super) rail: FixedStr<8>, // "V54_PSUx" | ||
| pub(super) slot: u8, |
Collaborator
There was a problem hiding this comment.
Could this be a PsuSlot instead? That would save some round-tripping through u8 / usize.
Member
Author
There was a problem hiding this comment.
Currently microcbor doesn't have a way to tell it to PsuSlot to serialize as an integer. I should add that, but was going to separately.
mkeeter
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2246 introduced the
microcborcrate for derivable CBOR serialization with a fixed max length. That branch changed the ereports indrv_gimlet_seq_serverto use the new derives. The intent at the time was to update other existing ereports, such as those indrv_psc_seq_server, separately. This branch does that.