Excavator: Format Java files

Author: svc-excavator-bot

.baseline/checkstyle/checkstyle.xml

@@ -173,6 +173,7 @@
         </module>
         <module name="IllegalType"> <!-- Java Coding Guide: Limit coupling on concrete classes -->
             <property name="illegalClassNames" value="java.util.ArrayList, java.util.HashSet, java.util.HashMap, java.util.LinkedList, java.util.LinkedHashMap, java.util.LinkedHashSet, java.util.TreeSet, java.util.TreeMap, com.google.common.collect.ArrayListMultimap, com.google.common.collect.ForwardingListMultimap, com.google.common.collect.ForwardingMultimap, com.google.common.collect.ForwardingSetMultimap, com.google.common.collect.ForwardingSortedSetMultimap, com.google.common.collect.HashMultimap, com.google.common.collect.LinkedHashMultimap, com.google.common.collect.LinkedListMultimap, com.google.common.collect.TreeMultimap"/>
+            <message key="illegal.type" value="Usage of type ''{0}'' is not allowed to limit coupling on concrete classes. For example, prefer Multimap over HashMultimap, List over ArrayList, and Set over TreeSet."/>
         </module>
         <module name="IllegalType">
             <property name="id" value="BanGuavaCaches"/>
@@ -292,14 +293,6 @@
             <property name="format" value="ImmutableSet\.Builder.*new ImmutableSet\.Builder"/>
             <property name="message" value="Use ImmutableSet.builder() for variable assignment."/>
         </module>
-        <module name="RegexpSinglelineJava"> <!-- Java Coding Guidelines: Check parameters for validity -->
-            <property name="format" value="Preconditions\.checkNotNull\((?!.*,)([^()]*(\(([^()]*|\(([^()]*|\([^()]*\))*\))*\)[^()]*)*)\)"/>
-            <property name="message" value="Use Preconditions.checkNotNull(Object, String)."/>
-        </module>
-        <module name="RegexpSinglelineJava"> <!-- Java Coding Guidelines: Check parameters for validity -->
-            <property name="format" value="Validate\.notNull\((?!.*,)([^()]*(\(([^()]*|\(([^()]*|\([^()]*\))*\))*\)[^()]*)*)\)"/>
-            <property name="message" value="Use Validate.notNull(Object, String)."/>
-        </module>
         <module name="RegexpSinglelineJava">
             <property name="format" value="^\s*super\(\);"/>
             <property name="message" value="This is unnecessary; please delete."/>

build.gradle

@@ -7,10 +7,10 @@ buildscript {
     dependencies {
         classpath 'com.palantir.gradle.jdkslatest:gradle-jdks-latest:0.15.0'
         classpath 'com.palantir.jakartapackagealignment:jakarta-package-alignment:0.6.0'
-        classpath 'com.palantir.baseline:gradle-baseline-java:6.25.0'
+        classpath 'com.palantir.baseline:gradle-baseline-java:6.51.0'
         classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:2.27.0'
         classpath 'com.palantir.gradle.gitversion:gradle-git-version:3.2.0'
-        classpath 'com.palantir.javaformat:gradle-palantir-java-format:2.62.0'
+        classpath 'com.palantir.javaformat:gradle-palantir-java-format:2.73.0'
         classpath 'com.palantir.suppressible-error-prone:gradle-suppressible-error-prone:2.9.0'
         classpath 'gradle.plugin.org.inferred:gradle-processors:3.7.0'
         classpath 'com.palantir.gradle.failure-reports:gradle-failure-reports:1.13.0'

lib/src/main/java/com/palantir/computemodules/auth/PipelinesAuth.java

@@ -17,6 +17,7 @@
 package com.palantir.computemodules.auth;
 
 import com.palantir.logsafe.exceptions.SafeRuntimeException;
+import com.palantir.logsafe.exceptions.SafeUncheckedIoException;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
@@ -37,7 +38,7 @@ public static String retrievePipelineToken() {
             return Files.readString(Paths.get(tokenFilePath), StandardCharsets.UTF_8)
                     .trim();
         } catch (IOException e) {
-            throw new SafeRuntimeException("Failed to read pipeline token from file where it is stored.", e);
+            throw new SafeUncheckedIoException("Failed to read pipeline token from file where it is stored.", e);
         }
     }
 }

lib/src/main/java/com/palantir/computemodules/auth/ThirdPartyAuth.java

@@ -19,6 +19,7 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.palantir.computemodules.ssl.SslUtils;
 import com.palantir.logsafe.exceptions.SafeRuntimeException;
+import com.palantir.logsafe.exceptions.SafeUncheckedIoException;
 import java.io.IOException;
 import java.net.URI;
 import java.net.URLEncoder;
@@ -84,7 +85,7 @@ public static String fetchOAuthToken(String hostname, List<String> scope) {
         } catch (InterruptedException e) {
             throw new SafeRuntimeException("Interrupted while fetching OAuth token", e);
         } catch (IOException e) {
-            throw new SafeRuntimeException("IOException while fetching OAuth token", e);
+            throw new SafeUncheckedIoException("IOException while fetching OAuth token", e);
         }
         return "";
     }

lib/src/main/java/com/palantir/computemodules/client/config/EnvVars.java

@@ -16,6 +16,7 @@
 package com.palantir.computemodules.client.config;
 
 import java.io.IOException;
+import java.io.UncheckedIOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Optional;
@@ -69,7 +70,7 @@ public String get() {
             try {
                 return Files.readString(Path.of(readAsString(name)));
             } catch (IOException e) {
-                throw new RuntimeException("Failed to read file pointed to by EnvVar: " + name, e);
+                throw new UncheckedIOException("Failed to read file pointed to by EnvVar: " + name, e);
             }
         }
     }