Tune GCP rules #1674
Open
Tune GCP rules #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idk why the test failed.... it failed for a rule that I didn't even edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We noticed some GCP rules are especially noisy and decided to investigate. These two are low-severity issues which don't need to be alerted on as much as they are.
Changes
GCP.Access.Attempts.Violating.VPC.Service.Controlsseveritydowngraded toLOWthresholdset to 1000runbookadded anddescriptionchanged slightlyGCP.K8s.Pod.Using.Host.PID.NamespaceTesting
GCP.Access.Attempts.Violating.VPC.Service.Controlswould be decreased from 666 alerts 👿 to 20, over a 6-week period.