Skip to content

Commit 1001ab6

Browse files
authored
Do not pass :for_input to super if it was used for tag groups
The plugin reuses the for_input tag to designate tags from specific tag groups. However, core expects that :for_input is used with a category, and if there are tag group restrictions it will honor them. If :for_input is passed to core without a category, any tags that contain to a tag group that is used in ANY category as a restricted tag group, are not returned. This makes the plugin unusable for assigning tags from restricted tag groups to a topic. At the moment CW uses the tag picker, it's not clear to which category the topic is going to be in, so passing the category together with :for_input is not an option. The only option left to make this work is to remove :for_input. This behavior is the same in the "experimental form templates" functionality, that also ignores restrictions on tag groups.
1 parent 6e1efdd commit 1001ab6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/custom_wizard/extensions/discourse_tagging.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ def filter_allowed_tags(guardian, opts = {})
1313

1414
opts[:only_tag_names] ||= []
1515
opts[:only_tag_names].push(*filtered_tags)
16+
opts.delete(:for_input)
1617
end
1718

1819
super

0 commit comments

Comments
 (0)