Skip to content

DEV: update deprecated icon name from caret-square-down to square-caret-down #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

DEV: update deprecated icon name from caret-square-down to square-caret-down #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3362ffc
DEV: update deprecated icon name from caret-square-down to square-car…
tyb-talks Mar 17, 2025
fb95f7d
update discourse-compat
tyb-talks Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .discourse-compatibility
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
< 3.3.0.beta1-dev: f3561ce7fd9dded965fb8e9a99229539c7af3aa1
< 3.4.0.beta2-dev: 7151c2cd4e150c70ad6b6e320369bec25c2df402
Copy link
Contributor Author

@tyb-talks tyb-talks Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

points to this commit: 7151c2c, and this version is the earliest when we have introduced the FA icon deprecation.

< 3.3.0.beta1-dev: f3561ce7fd9dded965fb8e9a99229539c7af3aa1
2 changes: 1 addition & 1 deletion about.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"assets": {},
"modifiers": {
"svg_icons": [
"caret-square-down"
"square-caret-down"
Copy link
Contributor Author

@tyb-talks tyb-talks Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the updated icon name we transform it to in the icon-library:
https://github.com/discourse/discourse/blob/013bf88019809513d101d9c48ee2b7bc373edcca/lib/deprecated_icon_handler.rb#L113

]
}
}
2 changes: 1 addition & 1 deletion javascripts/discourse/components/custom-header-links.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import Component from "@ember/component";
import { hash } from "@ember/helper";
import { action } from "@ember/object";
import { inject as service } from "@ember/service";

Check failure on line 5 in javascripts/discourse/components/custom-header-links.gjs

View workflow job for this annotation

GitHub Actions / ci / linting 

Use direct 'service' import instead of 'inject as service'
import DButton from "discourse/components/d-button";
import concatClass from "discourse/helpers/concat-class";
import closeOnClickOutside from "discourse/modifiers/close-on-click-outside";
Expand Down Expand Up @@ -40,7 +40,7 @@
{{#if this.site.mobileView}}
<span class="btn-custom-header-dropdown-mobile">
<DButton
@icon="caret-square-down"
@icon="square-caret-down"
@title={{i18n "custom_header.discord"}}
@action={{this.toggleHeaderLinks}}
/>
Expand Down
Loading