make Select all option in collection grid to work more like expected

[artimalternar]

Hi, currently if I use Select all option for the collection grid it would select only current page items

and if I switch to another page or change Per page number it would completly clean up all items checkboxes selection

It would be more expected if you Select All it would select all and remain checkboxes selected across all page changes and Per page changes.

[akhrarovsaid]

Hey @artimalternar

I distinctly remember looking into this a while ago. There was an open issue about navigating pages and the persistence of these selections. I think it's a lot easier said than done to be honest. From what I can recall, the issue is that these selections are stored in a map of ID's. Having an ID included means that the row is selected. The real issue being that when you select all, you don't load all ID's into the map, but use an enum that represents that all ID's are selected - this leads to the issue that when you navigate to the next page, none of the checkboxes will be visibly selected despite having "Select All" checked.

I think there is a somewhat complicated solution here in using a secondary Map for "exclusion" and switching between the two maps as necessary to dictate which rows are indeed selected, but this seems tricky and messy to me. I think the devs landed on the simpler, more maintainable solution in simply have selections scoped to each individual page, and I generally think it was the right move.

I think it's one of those things that seem really easy, but in practice is a little more complicated than it would appear with more nuances and edge cases.

[DanRibbens]

It would be more expected if you Select All it would select all and remain checkboxes selected across all page changes and Per page changes.

Gmail was inspiration for how Select All works in the list view. In Gmail if you select an email, go to the next page of results and select another and then delete, it will only delete the email on the page you're on. The first one you checked will not get deleted.

The actions that you can take after selecting many docs could be non-reversible and it is important that the user is doing this with great intention.

I do agree that when you navigate pages it would be nice if the selected docs checked were remembered. I am not certain the actions should apply docs on all pages when you bulk edit/delete. I haven't looked at this code lately but I think we could make that happen by keying the set per page in the selection provider context.

[artimalternar]

ok, but anyway

Select All (231) - is confusing, it does say that 231 docs ( which is really all items at all ) selected, but in reality it selects only items seen on a page