Skip to content

Commit cb20bba

Browse files
committed
chore: remove disabled tests
1 parent fab993e commit cb20bba

File tree

2 files changed

+7
-54
lines changed

2 files changed

+7
-54
lines changed

src/dev_codec_ans104.erl

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -447,24 +447,4 @@ field_and_tag_ordering_test() ->
447447
Wallet = hb:wallet(),
448448
SignedTABM = hb_message:commit(
449449
UnsignedTABM, #{priv_wallet => Wallet}, <<"[email protected]">>),
450-
?assert(hb_message:verify(SignedTABM)).
451-
452-
%% @doc This test is disabled until we can resolve an exception that gets
453-
%% thrown during the `to/3` call.
454-
nested_data_test_disabled() ->
455-
TABM = #{
456-
<<"tag">> => <<"level-1">>,
457-
<<"data">> => #{
458-
<<"tag">> => <<"level-2">>,
459-
<<"data">> => #{
460-
<<"tag">> => <<"level-3">>,
461-
<<"data">> => <<"nested-data">>
462-
}
463-
}
464-
},
465-
Wallet = hb:wallet(),
466-
SignedTABM = hb_message:commit(
467-
TABM, #{priv_wallet => Wallet}, <<"[email protected]">>),
468-
?assert(hb_message:verify(SignedTABM)),
469-
SignedTX = hb_util:ok(to(SignedTABM, #{}, #{})),
470-
?assert(ar_bundles:verify_item(SignedTX)).
450+
?assert(hb_message:verify(SignedTABM)).

src/dev_codec_tx.erl

Lines changed: 6 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -610,17 +610,8 @@ nested_data_tabm_test() ->
610610
<<"type">> => <<"rsa-pss-sha256">>,
611611
<<"bundle">> => <<"true">>
612612
},
613-
do_tabm_roundtrips(UnsignedTX, UnsignedTABM, NoLinksCommitment, true),
614-
615-
% XXX: Fails in some ans104 code, commenting out until we can resolve.
616-
% LinksCommitment = #{
617-
% <<"commitment-device">> => <<"[email protected]">>,
618-
% <<"committed">> => [<<"data+link">>, <<"tag">>],
619-
% <<"type">> => <<"rsa-pss-sha256">>,
620-
% <<"bundle">> => <<"false">>
621-
% },
622-
% do_tabm_roundtrips(UnsignedTX, UnsignedTABM, LinksCommitment, false),
623-
ok.
613+
% only bundle true is supported
614+
do_tabm_roundtrips(UnsignedTX, UnsignedTABM, NoLinksCommitment, true).
624615

625616
nested_non_data_key_tabm_test() ->
626617
UnsignedTABM = #{
@@ -664,17 +655,8 @@ nested_non_data_key_tabm_test() ->
664655
<<"type">> => <<"rsa-pss-sha256">>,
665656
<<"bundle">> => <<"true">>
666657
},
667-
do_tabm_roundtrips(UnsignedTX, UnsignedTABM, NoLinksCommitment, true),
668-
669-
% XXX: Fails in some ans104 code, commenting out until we can resolve.
670-
% LinksCommitment = #{
671-
% <<"commitment-device">> => <<"[email protected]">>,
672-
% <<"committed">> => [<<"a1+link">>, <<"tag1">>],
673-
% <<"type">> => <<"rsa-pss-sha256">>,
674-
% <<"bundle">> => <<"false">>
675-
% },
676-
% do_tabm_roundtrips(UnsignedTX, UnsignedTABM, LinksCommitment, false),
677-
ok.
658+
% only bundle true is supported
659+
do_tabm_roundtrips(UnsignedTX, UnsignedTABM, NoLinksCommitment, true).
678660

679661
nested_multiple_tabm_test() ->
680662
UnsignedTABM = #{
@@ -736,17 +718,8 @@ nested_multiple_tabm_test() ->
736718
<<"type">> => <<"rsa-pss-sha256">>,
737719
<<"bundle">> => <<"true">>
738720
},
739-
do_tabm_roundtrips(UnsignedTX, UnsignedTABM, NoLinksCommitment, true),
740-
741-
% XXX: Fails in some ans104 code, commenting out until we can resolve.
742-
% LinksCommitment = #{
743-
% <<"commitment-device">> => <<"[email protected]">>,
744-
% <<"committed">> => [<<"a1+link">>, <<"tag1">>],
745-
% <<"type">> => <<"rsa-pss-sha256">>,
746-
% <<"bundle">> => <<"false">>
747-
% },
748-
% do_tabm_roundtrips(UnsignedTX, UnsignedTABM, LinksCommitment, false),
749-
ok.
721+
% only bundle true is supported
722+
do_tabm_roundtrips(UnsignedTX, UnsignedTABM, NoLinksCommitment, true).
750723

751724
%% @doc This test is disabled for now. Unclear whether we should deserialize
752725
%% data by default. If we don't need to deserialize data, then this test

0 commit comments

Comments
 (0)